Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 899803004: Add GrGLCreateNullInterface.cpp back to gyp, and put contents in namespace. (Closed)

Created:
5 years, 10 months ago by bsalomon
Modified:
5 years, 10 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add GrGLCreateNullInterface.cpp back to gyp, and put contents in namespace. TBR=robertphillips@google.com Committed: https://skia.googlesource.com/skia/+/7e34007e1efe6b4e9b40109998a9c0b5b0ee9791

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M gyp/gpu.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLCreateNullInterface.cpp View 2 chunks +6 lines, -2 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
bsalomon
5 years, 10 months ago (2015-02-11 20:00:47 UTC) #2
bsalomon
https://codereview.chromium.org/899803004/diff/1/src/gpu/gl/GrGLCreateNullInterface.cpp File src/gpu/gl/GrGLCreateNullInterface.cpp (right): https://codereview.chromium.org/899803004/diff/1/src/gpu/gl/GrGLCreateNullInterface.cpp#newcode17 src/gpu/gl/GrGLCreateNullInterface.cpp:17: // added to suppress 'no previous prototype' warning and ...
5 years, 10 months ago (2015-02-11 20:01:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899803004/1
5 years, 10 months ago (2015-02-11 20:01:57 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 20:07:35 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7e34007e1efe6b4e9b40109998a9c0b5b0ee9791

Powered by Google App Engine
This is Rietveld 408576698