Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: minidump/minidump_memory_writer_test.cc

Issue 899793002: win: fix 'potentially uninitialized local variable' warnings (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@minidump_test
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_memory_writer_test.cc
diff --git a/minidump/minidump_memory_writer_test.cc b/minidump/minidump_memory_writer_test.cc
index e758216df4e540c3d12312515ce9e4d221a52da7..1aee35dee65247f85e08ab72874a9e6178107a35 100644
--- a/minidump/minidump_memory_writer_test.cc
+++ b/minidump/minidump_memory_writer_test.cc
@@ -88,7 +88,7 @@ TEST(MinidumpMemoryWriter, EmptyMemoryList) {
sizeof(MINIDUMP_MEMORY_LIST),
file_writer.string().size());
- const MINIDUMP_MEMORY_LIST* memory_list;
+ const MINIDUMP_MEMORY_LIST* memory_list = nullptr;
ASSERT_NO_FATAL_FAILURE(
GetMemoryListStream(file_writer.string(), &memory_list, 1));
@@ -112,7 +112,7 @@ TEST(MinidumpMemoryWriter, OneMemoryRegion) {
StringFileWriter file_writer;
ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer));
- const MINIDUMP_MEMORY_LIST* memory_list;
+ const MINIDUMP_MEMORY_LIST* memory_list = nullptr;
ASSERT_NO_FATAL_FAILURE(
GetMemoryListStream(file_writer.string(), &memory_list, 1));
@@ -153,7 +153,7 @@ TEST(MinidumpMemoryWriter, TwoMemoryRegions) {
StringFileWriter file_writer;
ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer));
- const MINIDUMP_MEMORY_LIST* memory_list;
+ const MINIDUMP_MEMORY_LIST* memory_list = nullptr;
ASSERT_NO_FATAL_FAILURE(
GetMemoryListStream(file_writer.string(), &memory_list, 1));
@@ -262,7 +262,7 @@ TEST(MinidumpMemoryWriter, ExtraMemory) {
StringFileWriter file_writer;
ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer));
- const MINIDUMP_MEMORY_LIST* memory_list;
+ const MINIDUMP_MEMORY_LIST* memory_list = nullptr;
ASSERT_NO_FATAL_FAILURE(
GetMemoryListStream(file_writer.string(), &memory_list, 2));
@@ -340,7 +340,7 @@ TEST(MinidumpMemoryWriter, AddFromSnapshot) {
StringFileWriter file_writer;
ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer));
- const MINIDUMP_MEMORY_LIST* memory_list;
+ const MINIDUMP_MEMORY_LIST* memory_list = nullptr;
ASSERT_NO_FATAL_FAILURE(
GetMemoryListStream(file_writer.string(), &memory_list, 1));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698