Send notificatinos after no-op changes.

pkg/analysis_server/lib/src/operation/operation_analysis.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library operation.analysis;
 
 import 'package:analysis_server/src/analysis_server.dart';
 import 'package:analysis_server/src/computer/computer_highlights.dart';
 import 'package:analysis_server/src/computer/computer_navigation.dart';
 import 'package:analysis_server/src/computer/computer_occurrences.dart';
 import 'package:analysis_server/src/computer/computer_outline.dart';
 import 'package:analysis_server/src/computer/computer_overrides.dart';
 import 'package:analysis_server/src/operation/operation.dart';
 import 'package:analysis_server/src/protocol_server.dart' as protocol;
 import 'package:analysis_server/src/services/index/index.dart';
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/error.dart';
 import 'package:analyzer/src/generated/html.dart';
 import 'package:analyzer/src/generated/source.dart';
 
 
+/**
+ * Schedules sending notifications for the given [file] using the resolved
+ * [resolvedDartUnit].
+ */
+void scheduleNotificationOperations(AnalysisServer server, String file,
+    LineInfo lineInfo, AnalysisContext context, CompilationUnit parsedDartUnit,
+    CompilationUnit resolvedDartUnit, List<AnalysisError> errors) {
+  // Only send notifications if the current context is the preferred
+  // context for the file.  This avoids redundant notification messages
+  // being sent to the client (see dartbug.com/22210).
+  // TODO(paulberry): note that there is a small risk that this will cause
+  // notifications to be lost if the preferred context for a file changes
+  // while analysis is in progress (e.g. because the client sent an
+  // analysis.setAnalysisRoots message).
+  if (server.getAnalysisContext(file) != context) {
+    return;
+  }
+  // Dart
+  CompilationUnit dartUnit =
+      resolvedDartUnit != null ? resolvedDartUnit : parsedDartUnit;
+  if (resolvedDartUnit != null) {
+    if (server.hasAnalysisSubscription(
+        protocol.AnalysisService.HIGHLIGHTS,
+        file)) {
+      server.scheduleOperation(
+          new _DartHighlightsOperation(file, resolvedDartUnit));
+    }
+    if (server.hasAnalysisSubscription(
+        protocol.AnalysisService.NAVIGATION,
+        file)) {
+      server.scheduleOperation(
+          new _DartNavigationOperation(file, resolvedDartUnit));
+    }
+    if (server.hasAnalysisSubscription(
+        protocol.AnalysisService.OCCURRENCES,
+        file)) {
+      server.scheduleOperation(
+          new _DartOccurrencesOperation(file, resolvedDartUnit));
+    }
+    if (server.hasAnalysisSubscription(
+        protocol.AnalysisService.OVERRIDES,
+        file)) {
+      server.scheduleOperation(
+          new _DartOverridesOperation(file, resolvedDartUnit));
+    }
+  }
+  if (dartUnit != null) {
+    if (server.hasAnalysisSubscription(
+        protocol.AnalysisService.OUTLINE,
+        file)) {
+      server.scheduleOperation(
+          new _DartOutlineOperation(file, lineInfo, dartUnit));
+    }
+  }
+  // errors
+  if (server.shouldSendErrorsNotificationFor(file)) {
+    server.scheduleOperation(
+        new _NotificationErrorsOperation(file, lineInfo, errors));
+  }
+}
+
+
 void sendAnalysisNotificationErrors(AnalysisServer server, String file,
     LineInfo lineInfo, List<AnalysisError> errors) {
   try {
     if (errors == null) {
       errors = <AnalysisError>[];
     }
     var serverErrors =
         protocol.doAnalysisError_listFromEngine(lineInfo, errors);
     var params = new protocol.AnalysisErrorsParams(file, serverErrors);
     server.sendNotification(params.toNotification());
@@ skipping 133 matching lines @@
   }
 
   /**
    * Send the information in the given list of notices back to the client.
    */
   void _sendNotices(AnalysisServer server, List<ChangeNotice> notices) {
     for (int i = 0; i < notices.length; i++) {
       ChangeNotice notice = notices[i];
       Source source = notice.source;
       String file = source.fullName;
-      // Only send notifications if the current context is the preferred
-      // context for the file.  This avoids redundant notification messages
-      // being sent to the client (see dartbug.com/22210).
-      // TODO(paulberry): note that there is a small risk that this will cause
-      // notifications to be lost if the preferred context for a file changes
-      // while analysis is in progress (e.g. because the client sent an
-      // analysis.setAnalysisRoots message).
-      if (server.getAnalysisContext(file) != context) {
-        continue;
-      }
       // Dart
       CompilationUnit parsedDartUnit = notice.parsedDartUnit;
       CompilationUnit resolvedDartUnit = notice.resolvedDartUnit;
-      CompilationUnit dartUnit =
-          resolvedDartUnit != null ? resolvedDartUnit : parsedDartUnit;
-      if (resolvedDartUnit != null) {
-        if (server.hasAnalysisSubscription(
-            protocol.AnalysisService.HIGHLIGHTS,
-            file)) {
-          server.addOperation(
-              new _DartHighlightsOperation(file, resolvedDartUnit));
-        }
-        if (server.hasAnalysisSubscription(
-            protocol.AnalysisService.NAVIGATION,
-            file)) {
-          server.addOperation(
-              new _DartNavigationOperation(file, resolvedDartUnit));
-        }
-        if (server.hasAnalysisSubscription(
-            protocol.AnalysisService.OCCURRENCES,
-            file)) {
-          server.addOperation(
-              new _DartOccurrencesOperation(file, resolvedDartUnit));
-        }
-        if (server.hasAnalysisSubscription(
-            protocol.AnalysisService.OVERRIDES,
-            file)) {
-          server.addOperation(
-              new _DartOverridesOperation(file, resolvedDartUnit));
-        }
-      }
-      if (dartUnit != null) {
-        if (server.hasAnalysisSubscription(
-            protocol.AnalysisService.OUTLINE,
-            file)) {
-          LineInfo lineInfo = notice.lineInfo;
-          server.addOperation(
-              new _DartOutlineOperation(file, lineInfo, dartUnit));
-        }
-      }
-      // errors
-      if (server.shouldSendErrorsNotificationFor(file)) {
-        server.addOperation(
-            new _NotificationErrorsOperation(file, notice.lineInfo, notice.errors));
-      }
+      scheduleNotificationOperations(
+          server,
+          file,
+          notice.lineInfo,
+          context,
+          parsedDartUnit,
+          resolvedDartUnit,
+          notice.errors);
       // done
       server.fileAnalyzed(notice);
     }
   }
 
   void _setCacheSize(int cacheSize) {
     AnalysisOptionsImpl options =
         new AnalysisOptionsImpl.con1(context.analysisOptions);
     options.cacheSize = cacheSize;
     context.analysisOptions = options;
@@ skipping 146 matching lines @@
   @override
   ServerOperationPriority get priority {
     return ServerOperationPriority.ANALYSIS_NOTIFICATION;
   }
 
   @override
   void perform(AnalysisServer server) {
     sendAnalysisNotificationErrors(server, file, lineInfo, errors);
   }
 }