sky/engine/core/rendering/RenderLineBoxList.h - Issue 899753003: Walk render tree instead of render layers for paint.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderLineBoxList.h

Issue 899753003: Walk render tree instead of render layers for paint. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: address review comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/engine/core/rendering/RenderLineBoxList.h

diff --git a/sky/engine/core/rendering/RenderLineBoxList.h b/sky/engine/core/rendering/RenderLineBoxList.h

index 74fad22c0ca335b9d07a65751bef26aa4bb07254..3d4e8f5c9c42a82d778cedfe2af7da7012ecc191 100644

--- a/sky/engine/core/rendering/RenderLineBoxList.h

+++ b/sky/engine/core/rendering/RenderLineBoxList.h

@@ -63,7 +63,7 @@ public:

void dirtyLineBoxes();

void dirtyLinesFromChangedChild(RenderObject* parent, RenderObject* child);

- void paint(RenderBoxModelObject*, PaintInfo&, const LayoutPoint&) const;

+ void paint(RenderBoxModelObject*, PaintInfo&, const LayoutPoint&, Vector<RenderBox*>& layers) const;

bool hitTest(RenderBoxModelObject*, const HitTestRequest&, HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction) const;

private:

« no previous file with comments | « sky/engine/core/rendering/RenderLayer.cpp ('k') | sky/engine/core/rendering/RenderLineBoxList.cpp » ('j') | no next file with comments »