sky/engine/core/rendering/RenderBlock.h - Issue 899753003: Walk render tree instead of render layers for paint.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderBlock.h

Issue 899753003: Walk render tree instead of render layers for paint. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: address review comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/RenderBlock.h

diff --git a/sky/engine/core/rendering/RenderBlock.h b/sky/engine/core/rendering/RenderBlock.h

index 807c43ad7d8d0b1e7a6d3ba5aaa95d2babc1fb08..37ae909521d923110b1183d29c4ebe552cf06adb 100644

--- a/sky/engine/core/rendering/RenderBlock.h

+++ b/sky/engine/core/rendering/RenderBlock.h

@@ -210,9 +210,9 @@ protected:

int beforeMarginInLineDirection(LineDirectionMode) const;

- virtual void paint(PaintInfo&, const LayoutPoint&) override;

- virtual void paintObject(PaintInfo&, const LayoutPoint&) override;

- virtual void paintChildren(PaintInfo&, const LayoutPoint&);

+ virtual void paint(PaintInfo&, const LayoutPoint&, Vector<RenderBox*>& layers) override;

+ void paintObject(PaintInfo&, const LayoutPoint&, Vector<RenderBox*>& layers);

+ virtual void paintChildren(PaintInfo&, const LayoutPoint&, Vector<RenderBox*>& layers);

virtual void adjustInlineDirectionLineBounds(unsigned /* expansionOpportunityCount */, float& /* logicalLeft */, float& /* logicalWidth */) const { }