sky/engine/core/rendering/RootInlineBox.h - Issue 899753003: Walk render tree instead of render layers for paint.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RootInlineBox.h

Issue 899753003: Walk render tree instead of render layers for paint. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sky/engine/core/rendering/RenderBox.cpp ('K') | « sky/engine/core/rendering/RenderView.cpp ('k') | sky/engine/core/rendering/RootInlineBox.cpp » ('j') | sky/engine/core/rendering/RootInlineBox.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sky/engine/core/rendering/RootInlineBox.h

diff --git a/sky/engine/core/rendering/RootInlineBox.h b/sky/engine/core/rendering/RootInlineBox.h

index 5b616f1df90f70ad7c5b9a344672b64083d8361e..fcc8327cd9f4b3e9bb848629af0656daf5a396e1 100644

--- a/sky/engine/core/rendering/RootInlineBox.h

+++ b/sky/engine/core/rendering/RootInlineBox.h

@@ -102,14 +102,14 @@ public:

using InlineBox::hasEllipsisBox;

EllipsisBox* ellipsisBox() const;

- void paintEllipsisBox(PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, LayoutUnit lineBottom) const;

+ void paintEllipsisBox(PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, LayoutUnit lineBottom, Vector<RenderBox*> layers) const;

virtual void clearTruncation() override final;

virtual int baselinePosition(FontBaseline baselineType) const override final;

virtual LayoutUnit lineHeight() const override final;

- virtual void paint(PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, LayoutUnit lineBottom) override;

+ virtual void paint(PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, LayoutUnit lineBottom, Vector<RenderBox*> layers) override;

virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, LayoutUnit lineTop, LayoutUnit lineBottom) override final;

using InlineBox::hasSelectedChildren;