sky/engine/core/rendering/RenderText.h - Issue 899753003: Walk render tree instead of render layers for paint.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderText.h

Issue 899753003: Walk render tree instead of render layers for paint. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sky/engine/core/rendering/RenderBox.cpp ('K') | « sky/engine/core/rendering/RenderReplaced.cpp ('k') | sky/engine/core/rendering/RenderView.h » ('j') | sky/engine/core/rendering/RootInlineBox.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sky/engine/core/rendering/RenderText.h

diff --git a/sky/engine/core/rendering/RenderText.h b/sky/engine/core/rendering/RenderText.h

index 19066429e55708120d15610f66396b4459325202..1e9f9cc2163b643514227be407a9dbe7c75bbee0 100644

--- a/sky/engine/core/rendering/RenderText.h

+++ b/sky/engine/core/rendering/RenderText.h

@@ -154,7 +154,7 @@ private:

// callers with a RenderObject* can continue to use length().

virtual unsigned length() const override final { return textLength(); }

- virtual void paint(PaintInfo&, const LayoutPoint&) override final { ASSERT_NOT_REACHED(); }

+ virtual void paint(PaintInfo&, const LayoutPoint&, Vector<RenderBox*>& layers) override final { ASSERT_NOT_REACHED(); }

virtual void layout() override final { ASSERT_NOT_REACHED(); }

virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTestLocation&, const LayoutPoint&, HitTestAction) override final { ASSERT_NOT_REACHED(); return false; }