sky/engine/core/rendering/InlineTextBox.cpp - Issue 899753003: Walk render tree instead of render layers for paint.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/InlineTextBox.cpp

Issue 899753003: Walk render tree instead of render layers for paint. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sky/engine/core/rendering/InlineFlowBox.cpp ('K') | « sky/engine/core/rendering/InlineTextBox.h ('k') | sky/engine/core/rendering/RenderBlock.h » ('j') | sky/engine/core/rendering/RenderBox.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sky/engine/core/rendering/InlineTextBox.cpp

diff --git a/sky/engine/core/rendering/InlineTextBox.cpp b/sky/engine/core/rendering/InlineTextBox.cpp

index 6fe8624030bc5d523938865a36e1e522326c1df5..25bf38cf035cbf094eee91c5ec73c9c928391e2d 100644

--- a/sky/engine/core/rendering/InlineTextBox.cpp

+++ b/sky/engine/core/rendering/InlineTextBox.cpp

@@ -478,7 +478,7 @@ void paintTextWithEmphasisMark(

} // namespace

-void InlineTextBox::paint(PaintInfo& paintInfo, const LayoutPoint& paintOffset, LayoutUnit /*lineTop*/, LayoutUnit /*lineBottom*/)

+void InlineTextBox::paint(PaintInfo& paintInfo, const LayoutPoint& paintOffset, LayoutUnit /*lineTop*/, LayoutUnit /*lineBottom*/, Vector<RenderBox*> layers)

esprehn 2015/02/05 23:47:00 Vector<RenderBox*>&, you're making copies all over

{

if (isLineBreak() || m_truncation == cFullTruncation || !m_len)

return;