Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Side by Side Diff: sky/engine/core/rendering/InlineBox.cpp

Issue 899753003: Walk render tree instead of render layers for paint. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: address review comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/rendering/InlineBox.h ('k') | sky/engine/core/rendering/InlineFlowBox.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 } 184 }
185 185
186 void InlineBox::adjustPosition(float dx, float dy) 186 void InlineBox::adjustPosition(float dx, float dy)
187 { 187 {
188 m_topLeft.move(dx, dy); 188 m_topLeft.move(dx, dy);
189 189
190 if (renderer().isReplaced()) 190 if (renderer().isReplaced())
191 toRenderBox(renderer()).move(dx, dy); 191 toRenderBox(renderer()).move(dx, dy);
192 } 192 }
193 193
194 void InlineBox::paint(PaintInfo& paintInfo, const LayoutPoint& paintOffset, Layo utUnit /* lineTop */, LayoutUnit /*lineBottom*/) 194 void InlineBox::paint(PaintInfo& paintInfo, const LayoutPoint& paintOffset, Layo utUnit /* lineTop */, LayoutUnit /*lineBottom*/, Vector<RenderBox*>& layers)
195 { 195 {
196 renderer().paint(paintInfo, paintOffset); 196 renderer().paint(paintInfo, paintOffset, layers);
197 } 197 }
198 198
199 bool InlineBox::nodeAtPoint(const HitTestRequest& request, HitTestResult& result , const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffs et, LayoutUnit /* lineTop */, LayoutUnit /*lineBottom*/) 199 bool InlineBox::nodeAtPoint(const HitTestRequest& request, HitTestResult& result , const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffs et, LayoutUnit /* lineTop */, LayoutUnit /*lineBottom*/)
200 { 200 {
201 // Hit test all phases of replaced elements atomically, as though the replac ed element established its 201 // Hit test all phases of replaced elements atomically, as though the replac ed element established its
202 // own stacking context. (See Appendix E.2, section 6.4 on inline block/tab le elements in the CSS2.1 202 // own stacking context. (See Appendix E.2, section 6.4 on inline block/tab le elements in the CSS2.1
203 // specification.) 203 // specification.)
204 LayoutPoint childPoint = accumulatedOffset; 204 LayoutPoint childPoint = accumulatedOffset;
205 return renderer().hitTest(request, result, locationInContainer, childPoint); 205 return renderer().hitTest(request, result, locationInContainer, childPoint);
206 } 206 }
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
318 b->showTreeForThis(); 318 b->showTreeForThis();
319 } 319 }
320 320
321 void showLineTree(const blink::InlineBox* b) 321 void showLineTree(const blink::InlineBox* b)
322 { 322 {
323 if (b) 323 if (b)
324 b->showLineTreeForThis(); 324 b->showLineTreeForThis();
325 } 325 }
326 326
327 #endif 327 #endif
OLDNEW
« no previous file with comments | « sky/engine/core/rendering/InlineBox.h ('k') | sky/engine/core/rendering/InlineFlowBox.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698