Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 899743002: Unify GPU raster and canvas blacklists on Android, second attempt. (Closed)

Created:
5 years, 10 months ago by aelias_OOO_until_Jul13
Modified:
5 years, 10 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unify GPU raster and canvas blacklists on Android, second attempt. Accelerated canvas and GPU raster both use the same Skia codepaths and have generally displayed the same bugs. It doesn't make sense to blacklist one but not the other. Since GPU raster sees more usage than canvas nowadays, and I researched GPU raster compatibility as part of https://codereview.chromium.org/760053003, it makes sense to fold canvas into the same blacklist. This immediately fixes an Adreno 225 canvas bug which slipped through a driver-reported-version based blacklist, which is apparently unreliable and which I deleted in this patch. More generally it also should avoid this kind of issue in the future. This patch is similar to the previous version, but also makes the Mali-T604 blacklist entry specific to Android, since it was inadvertently affecting ChromeOS. BUG=453283, 454547 Committed: https://crrev.com/6cf89e9e1bb60e0025083582f61a0fed62fefd9c Cr-Commit-Position: refs/heads/master@{#314637}

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -21 lines) Patch
M gpu/config/software_rendering_list_json.cc View 1 5 chunks +10 lines, -21 lines 1 comment Download

Messages

Total messages: 13 (4 generated)
aelias_OOO_until_Jul13
Hi zmo@, PTAL. This has an additional OS=android check to address http://crbug.com/454547
5 years, 10 months ago (2015-02-04 01:38:22 UTC) #2
Zhenyao Mo
https://codereview.chromium.org/899743002/diff/20001/gpu/config/software_rendering_list_json.cc File gpu/config/software_rendering_list_json.cc (right): https://codereview.chromium.org/899743002/diff/20001/gpu/config/software_rendering_list_json.cc#newcode1101 gpu/config/software_rendering_list_json.cc:1101: "type": "android" Now this change affects other platforms (say, ...
5 years, 10 months ago (2015-02-04 02:01:27 UTC) #3
aelias_OOO_until_Jul13
On 2015/02/04 at 02:01:27, zmo wrote: > https://codereview.chromium.org/899743002/diff/20001/gpu/config/software_rendering_list_json.cc > File gpu/config/software_rendering_list_json.cc (right): > > https://codereview.chromium.org/899743002/diff/20001/gpu/config/software_rendering_list_json.cc#newcode1101 ...
5 years, 10 months ago (2015-02-04 02:14:34 UTC) #4
Zhenyao Mo
LGTM
5 years, 10 months ago (2015-02-04 17:06:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899743002/20001
5 years, 10 months ago (2015-02-04 19:08:01 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/54977)
5 years, 10 months ago (2015-02-04 19:36:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899743002/20001
5 years, 10 months ago (2015-02-04 20:29:06 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-04 21:20:56 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 21:23:27 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6cf89e9e1bb60e0025083582f61a0fed62fefd9c
Cr-Commit-Position: refs/heads/master@{#314637}

Powered by Google App Engine
This is Rietveld 408576698