Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 899723003: aura: Add missing test file to ozone GN build (Closed)

Created:
5 years, 10 months ago by spang
Modified:
5 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aura: Add missing test file to ozone GN build It is already in the GYP build. BUG=445627 TEST=gn gen out_gn_ozone --args='os="chromeos" use_ozone=true is_component_build=true' && ninja -C out_gn_ozone chrome ozone_unittests (along with other needed changes) Committed: https://crrev.com/6f171acafbe8b796db44691e1bafecb2319f4e01 Cr-Commit-Position: refs/heads/master@{#314595}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ui/aura/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
spang
5 years, 10 months ago (2015-02-04 01:08:32 UTC) #2
sky
LGTM
5 years, 10 months ago (2015-02-04 18:05:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899723003/1
5 years, 10 months ago (2015-02-04 18:06:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 18:47:01 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6f171acafbe8b796db44691e1bafecb2319f4e01 Cr-Commit-Position: refs/heads/master@{#314595}
5 years, 10 months ago (2015-02-04 18:48:10 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 18:48:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f171acafbe8b796db44691e1bafecb2319f4e01
Cr-Commit-Position: refs/heads/master@{#314595}

Powered by Google App Engine
This is Rietveld 408576698