Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Issue 899693002: Add a src-side script to display a summary of host info. (Closed)

Created:
5 years, 10 months ago by shatch
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a src-side script to display a summary of host info. The idea being that this make it easier to diagnose and fix issues like http://crbug.com/439598. Sample run: http://simonhatch0.mon.corp.google.com:8013/builders/Android%20Nexus7v2%20Perf/builds/337/steps/host_info/logs/json.output The output from this run on the Nexus 7v2 bots looks like: { "failures": [ "build_versions" ], "host_info": { "devices": { "build_types": "userdebug/dev-keys", "build_versions": "MISMATCH", "build_versions_list": [ "4.4.2/KOT49H/937116", "5.0/LRX21P/1570855" ], "device_names": "google/razor/flo", "devices": [ "09275b25", "09e0cda5", "09e19954", "09e19f78", "09e28a6c", "0a38ca3e", "0a9f170a", "0a9f1772" ] }, "free_disk_space": 543.9997482299805, "num_cpus": 40, "os_release": "3.13.0-44-generic", "os_system": "Linux", "processor": "x86_64", "python_path": "/usr/bin/python", "python_version": "2.7.6" }, "valid": false } This can be enabled by adding this to testing/buildbot/chromium.perf.json: { "Android Nexus7v2 Perf": { "scripts": [ { "name": "host_info", "script": "host_info.py" } ] } } Needs to land before enabling (that CL enables src-side tests for perf bots): https://codereview.chromium.org/873403002/ BUG=443708, 454934 Committed: https://crrev.com/1730cecbc05928e93e2dec826a67139bf6765cc6 Cr-Commit-Position: refs/heads/master@{#316651}

Patch Set 1 #

Patch Set 2 : Misc. #

Total comments: 11

Patch Set 3 : Changes from review. #

Total comments: 2

Patch Set 4 : Changed valid to true. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -0 lines) Patch
A testing/scripts/host_info.py View 1 2 3 1 chunk +136 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
shatch
Hey Annie, want to take a look at the output before I send this out? ...
5 years, 10 months ago (2015-02-03 20:44:03 UTC) #2
sullivan
On 2015/02/03 20:44:03, shatch wrote: > Hey Annie, want to take a look at the ...
5 years, 10 months ago (2015-02-04 04:26:15 UTC) #3
shatch
phajdan is OOO this week, ptal https://codereview.chromium.org/899693002/diff/40001/testing/scripts/host_info.py File testing/scripts/host_info.py (right): https://codereview.chromium.org/899693002/diff/40001/testing/scripts/host_info.py#newcode122 testing/scripts/host_info.py:122: 'host_info': host_info, I'm ...
5 years, 10 months ago (2015-02-04 15:46:18 UTC) #6
shatch
Adding phajdan since he's back this week.
5 years, 10 months ago (2015-02-09 21:26:41 UTC) #8
Paweł Hajdan Jr.
https://codereview.chromium.org/899693002/diff/40001/testing/scripts/host_info.py File testing/scripts/host_info.py (right): https://codereview.chromium.org/899693002/diff/40001/testing/scripts/host_info.py#newcode34 testing/scripts/host_info.py:34: assert False, 'OS %s not supported.' % os.name I'd ...
5 years, 10 months ago (2015-02-10 08:34:12 UTC) #9
shatch
ptal https://codereview.chromium.org/899693002/diff/40001/testing/scripts/host_info.py File testing/scripts/host_info.py (right): https://codereview.chromium.org/899693002/diff/40001/testing/scripts/host_info.py#newcode34 testing/scripts/host_info.py:34: assert False, 'OS %s not supported.' % os.name ...
5 years, 10 months ago (2015-02-10 16:42:58 UTC) #11
shatch
On 2015/02/10 16:42:58, shatch wrote: > ptal > > https://codereview.chromium.org/899693002/diff/40001/testing/scripts/host_info.py > File testing/scripts/host_info.py (right): > ...
5 years, 10 months ago (2015-02-17 15:28:50 UTC) #12
Paweł Hajdan Jr.
https://codereview.chromium.org/899693002/diff/80001/testing/scripts/host_info.py File testing/scripts/host_info.py (right): https://codereview.chromium.org/899693002/diff/80001/testing/scripts/host_info.py#newcode119 testing/scripts/host_info.py:119: 'valid': bool(not failures), This is _valid_ , not e.g. ...
5 years, 10 months ago (2015-02-17 16:07:01 UTC) #13
shatch
https://codereview.chromium.org/899693002/diff/80001/testing/scripts/host_info.py File testing/scripts/host_info.py (right): https://codereview.chromium.org/899693002/diff/80001/testing/scripts/host_info.py#newcode119 testing/scripts/host_info.py:119: 'valid': bool(not failures), On 2015/02/17 16:07:01, Paweł Hajdan Jr. ...
5 years, 10 months ago (2015-02-17 16:49:22 UTC) #14
Paweł Hajdan Jr.
LGTM
5 years, 10 months ago (2015-02-17 17:29:08 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899693002/100001
5 years, 10 months ago (2015-02-17 20:40:24 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:100001)
5 years, 10 months ago (2015-02-17 21:05:49 UTC) #18
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 21:06:32 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/1730cecbc05928e93e2dec826a67139bf6765cc6
Cr-Commit-Position: refs/heads/master@{#316651}

Powered by Google App Engine
This is Rietveld 408576698