Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: components/enhanced_bookmarks/bookmark_image_service.h

Issue 899653003: [Enhanced Bookmark]Upstream image fetching code in android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | components/enhanced_bookmarks/bookmark_image_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/enhanced_bookmarks/bookmark_image_service.h
diff --git a/components/enhanced_bookmarks/bookmark_image_service.h b/components/enhanced_bookmarks/bookmark_image_service.h
index 53bd47c5eb90cc44e28add1c4c7914ed7c0d8bd7..8ec1fa8a86251fc1f9d4c9520e83a8775efd84d4 100644
--- a/components/enhanced_bookmarks/bookmark_image_service.h
+++ b/components/enhanced_bookmarks/bookmark_image_service.h
@@ -84,8 +84,8 @@ class BookmarkImageService : public KeyedService,
// Returns true if the image for the page_url is currently being fetched.
bool IsPageUrlInProgress(const GURL& page_url);
- // Once an image has been retrieved, store the image and notify all the
- // consumers that were waiting on it.
+ // Stores the image to local storage. If update_bookmarks is true, relates the
+ // corresponding bookmark to image_url.
void ProcessNewImage(const GURL& page_url,
bool update_bookmarks,
const gfx::Image& image,
@@ -113,10 +113,10 @@ class BookmarkImageService : public KeyedService,
EnhancedBookmarkModel* enhanced_bookmark_model_;
private:
- // Same as SalientImageForUrl(const GURL&, ImageCallback) but can
- // prevent the network request if fetch_from_bookmark is false.
+ // If fetch_from_web is true, retrieves the salient image via a network
+ // request; else only gets the image from local storage.
void SalientImageForUrl(const GURL& page_url,
- bool fetch_from_bookmark,
+ bool fetch_from_web,
ImageCallback stack_callback);
// Processes the requests that have been waiting on an image.
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | components/enhanced_bookmarks/bookmark_image_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698