components/enhanced_bookmarks/bookmark_image_service.cc - Issue 899653003: [Enhanced Bookmark]Upstream image fetching code in android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/enhanced_bookmarks/bookmark_image_service.cc

Issue 899653003: [Enhanced Bookmark]Upstream image fetching code in android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: reverted change in bookmark_image_service Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/enhanced_bookmarks/bookmark_image_service.cc

diff --git a/components/enhanced_bookmarks/bookmark_image_service.cc b/components/enhanced_bookmarks/bookmark_image_service.cc

index c2c019e7677ac4c38038a0433dfd5e63ae3db131..bbec3b1b357aa8f8c6c18d9a5c16beddf0b04dbf 100644

--- a/components/enhanced_bookmarks/bookmark_image_service.cc

+++ b/components/enhanced_bookmarks/bookmark_image_service.cc

@@ -165,7 +165,7 @@ void BookmarkImageService::FetchCallback(const GURL& page_url,

}

void BookmarkImageService::SalientImageForUrl(const GURL& page_url,

- bool fetch_from_bookmark,

+ bool fetch_from_web,

ImageCallback callback) {

DCHECK(CalledOnValidThread());

@@ -176,7 +176,7 @@ void BookmarkImageService::SalientImageForUrl(const GURL& page_url,

return;

}

- if (!fetch_from_bookmark) {

+ if (!fetch_from_web) {

RetrieveImageFromStore(page_url, callback);

} else {

RetrieveImageFromStore(page_url,

« no previous file with comments | « components/enhanced_bookmarks/bookmark_image_service.h ('k') | no next file » | no next file with comments »