Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: chrome/browser/enhanced_bookmarks/android/bookmark_image_service_android.cc

Issue 899653003: [Enhanced Bookmark]Upstream image fetching code in android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: reverted change in bookmark_image_service Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "base/json/json_parser.h"
6 #include "base/strings/utf_string_conversions.h"
7 #include "base/values.h"
8 #include "chrome/browser/bitmap_fetcher/bitmap_fetcher.h"
9 #include "chrome/browser/enhanced_bookmarks/android/bookmark_image_service_andro id.h"
10 #include "chrome/browser/enhanced_bookmarks/enhanced_bookmark_model_factory.h"
11 #include "chrome/grit/browser_resources.h"
12 #include "components/bookmarks/browser/bookmark_model.h"
13 #include "components/enhanced_bookmarks/enhanced_bookmark_model.h"
14 #include "content/public/browser/browser_context.h"
15 #include "content/public/browser/browser_thread.h"
16 #include "content/public/browser/navigation_entry.h"
17 #include "content/public/browser/render_frame_host.h"
18 #include "content/public/browser/web_contents.h"
19 #include "content/public/common/referrer.h"
20 #include "net/base/load_flags.h"
21 #include "ui/base/resource/resource_bundle.h"
22 #include "ui/gfx/image/image_skia.h"
23
24 using content::Referrer;
25
26 namespace enhanced_bookmarks {
27
28 BookmarkImageServiceAndroid::BookmarkImageServiceAndroid(
29 content::BrowserContext* browserContext)
30 : BookmarkImageService(
31 browserContext->GetPath(),
32 EnhancedBookmarkModelFactory::GetForBrowserContext(browserContext),
33 make_scoped_refptr(content::BrowserThread::GetBlockingPool())),
34 browser_context_(browserContext) {
35 }
36
37 void BookmarkImageServiceAndroid::RetrieveSalientImage(
38 const GURL& page_url,
39 const GURL& image_url,
40 const std::string& referrer,
41 net::URLRequest::ReferrerPolicy referrer_policy,
42 bool update_bookmark) {
43 const BookmarkNode* bookmark =
44 enhanced_bookmark_model_->bookmark_model()
45 ->GetMostRecentlyAddedUserNodeForURL(page_url);
46 if (!bookmark || !image_url.is_valid()) {
47 ProcessNewImage(page_url, update_bookmark, gfx::Image(), image_url);
48 return;
49 }
50
51 BitmapFetcherHandler* bitmap_fetcher_handler =
52 new BitmapFetcherHandler(this, image_url);
53 bitmap_fetcher_handler->Start(
54 browser_context_, referrer, referrer_policy,
55 net::LOAD_DO_NOT_SEND_COOKIES | net::LOAD_DO_NOT_SAVE_COOKIES,
56 update_bookmark, page_url);
57 }
58
59 void BookmarkImageServiceAndroid::RetrieveSalientImageFromContext(
60 content::RenderFrameHost* render_frame_host,
61 const GURL& page_url,
62 bool update_bookmark) {
63 DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
64 if (IsPageUrlInProgress(page_url))
65 return; // A request for this URL is already in progress.
66
67 const BookmarkNode* bookmark = enhanced_bookmark_model_->bookmark_model()
68 ->GetMostRecentlyAddedUserNodeForURL(page_url);
69 if (!bookmark)
70 return;
71
72 // Stop the image extraction if there is already an image present.
73 GURL url;
74 int height, width;
75 if (enhanced_bookmark_model_->GetOriginalImage(bookmark, &url, &width,
76 &height) ||
77 enhanced_bookmark_model_->GetThumbnailImage(bookmark, &url, &width,
78 &height)) {
79 return;
80 }
81
82 if (script_.empty()) {
83 script_ =
84 base::UTF8ToUTF16(ResourceBundle::GetSharedInstance()
85 .GetRawDataResource(IDR_GET_SALIENT_IMAGE_URL_JS)
86 .as_string());
87 }
88
89 render_frame_host->ExecuteJavaScript(
90 script_,
91 base::Bind(
92 &BookmarkImageServiceAndroid::RetrieveSalientImageFromContextCallback,
93 base::Unretained(this), page_url, update_bookmark));
94 }
95
96 void BookmarkImageServiceAndroid::FinishSuccessfulPageLoadForTab(
97 content::WebContents* web_contents, bool update_bookmark) {
98 content::NavigationEntry* entry =
99 web_contents->GetController().GetVisibleEntry();
100
101 // If the navigation is a simple back or forward, do not extract images, those
102 // were extracted already.
103 if (!entry || (entry->GetTransitionType() & ui::PAGE_TRANSITION_FORWARD_BACK))
104 return;
105 const GURL& entry_url = entry->GetURL();
106 const GURL& entry_original_url = entry->GetOriginalRequestURL();
107 std::vector<GURL> urls;
108 urls.push_back(entry_url);
109 if (entry_url != entry_original_url)
110 urls.push_back(entry_original_url);
111 for (GURL url : urls) {
112 if (enhanced_bookmark_model_->bookmark_model()->IsBookmarked(url)) {
113 RetrieveSalientImageFromContext(web_contents->GetMainFrame(), url,
114 update_bookmark);
115 }
116 }
117 }
118
119 void BookmarkImageServiceAndroid::RetrieveSalientImageFromContextCallback(
120 const GURL& page_url,
121 bool update_bookmark,
122 const base::Value* result) {
123 if (!result)
124 return;
125
126 std::string json;
127 if (!result->GetAsString(&json)) {
128 LOG(WARNING)
129 << "Salient image extracting script returned non-string result.";
130 return;
131 }
132
133 scoped_ptr<base::Value> json_data;
134 int error_code = 0;
135 std::string errorMessage;
136 json_data.reset(base::JSONReader::ReadAndReturnError(
137 json, base::JSON_PARSE_RFC, &error_code, &errorMessage));
138 if (error_code || !json_data) {
139 LOG(WARNING) << "JSON parse error: " << errorMessage.c_str() << json;
140 return;
141 }
142
143 base::DictionaryValue* dict;
144 if (!json_data->GetAsDictionary(&dict)) {
145 LOG(WARNING) << "JSON parse error, not a dict: " << json;
146 return;
147 }
148
149 std::string referrerPolicy;
150 std::string image_url;
151 dict->GetString("referrerPolicy", &referrerPolicy);
152 dict->GetString("imageUrl", &image_url);
153
154 // The policy strings are guaranteed to be in lower-case.
155 blink::WebReferrerPolicy policy = blink::WebReferrerPolicyDefault;
156 if (referrerPolicy == "never")
157 policy = blink::WebReferrerPolicyNever;
158 if (referrerPolicy == "always")
159 policy = blink::WebReferrerPolicyAlways;
160 if (referrerPolicy == "origin")
161 policy = blink::WebReferrerPolicyOrigin;
162
163 in_progress_page_urls_.insert(page_url);
164
165 Referrer referrer =
166 Referrer::SanitizeForRequest(GURL(image_url), Referrer(page_url, policy));
167 net::URLRequest::ReferrerPolicy referrer_policy =
168 net::URLRequest::CLEAR_REFERRER_ON_TRANSITION_FROM_SECURE_TO_INSECURE;
169 if (!referrer.url.is_empty()) {
170 switch (policy) {
171 case blink::WebReferrerPolicyDefault:
172 break;
173 case blink::WebReferrerPolicyAlways:
174 case blink::WebReferrerPolicyNever:
175 case blink::WebReferrerPolicyOrigin:
176 referrer_policy = net::URLRequest::NEVER_CLEAR_REFERRER;
177 break;
178 default:
179 NOTREACHED();
180 }
181 }
182 RetrieveSalientImage(page_url, GURL(image_url), referrer.url.spec(),
183 referrer_policy, update_bookmark);
184 }
185
186 void BookmarkImageServiceAndroid::BitmapFetcherHandler::Start(
187 content::BrowserContext* browser_context,
188 const std::string& referrer,
189 net::URLRequest::ReferrerPolicy referrer_policy,
190 int load_flags,
191 bool update_bookmark,
192 const GURL& page_url) {
193 update_bookmark_ = update_bookmark;
194 page_url_ = page_url;
195
196 bitmap_fetcher_.Start(browser_context->GetRequestContext(), referrer,
197 referrer_policy, load_flags);
198 }
199
200 void BookmarkImageServiceAndroid::BitmapFetcherHandler::OnFetchComplete(
201 const GURL url,
202 const SkBitmap* bitmap) {
203 DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
204
205 gfx::Image image;
206 if (bitmap) {
207 gfx::ImageSkia imageSkia = gfx::ImageSkia::CreateFrom1xBitmap(*bitmap);
208 imageSkia.MakeThreadSafe();
209 image = gfx::Image(imageSkia);
210 }
211 service_->ProcessNewImage(page_url_, update_bookmark_, image, url);
212
213 delete this;
214 }
215
216 } // namespace enhanced_bookmarks
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698