Use ExclusiveStreamReader to lock Body.

Use ExclusiveStreamReader to lock Body.

Use ExclusiveStreamReader to forbid a user from reading data via body
attribute.

BUG=435393
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189611

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190637

[yhirano, 2015-02-04 02:06:59]

yhirano@chromium.org changed reviewers:
+ horo@chromium.org

[yhirano, 2015-02-05 02:21:05]

On 2015/02/04 02:07:00, yhirano wrote:

This CL depends on a reverted CL https://codereview.chromium.org/837673002/. I
will reland it when I fix the problem.

[horo, 2015-02-05 14:05:08]

lgtm

[yhirano, 2015-02-06 03:01:52]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2015-02-06 03:02:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/899653002/60001

[commit-bot: I haz the power, 2015-02-06 04:41:21]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189611

[yhirano, 2015-02-06 14:04:45]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/883323004/ by yhirano@chromium.org.

The reason for reverting is: This change may cause a test crash:
https://crbug.com/456047.

[yhirano, 2015-02-06 16:42:19]

reopen

[yhirano, 2015-02-23 03:53:46]

Reland because the blocking CL is landed.
https://codereview.chromium.org/942433003/

[yhirano, 2015-02-23 03:53:50]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2015-02-23 03:54:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/899653002/60001

[commit-bot: I haz the power, 2015-02-23 03:54:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-23 03:54:43]

Failed to apply patch for
LayoutTests/http/tests/fetch/script-tests/stream-reader.js:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/http/tests/fetch/script-tests/stream-reader.js
  Hunk #1 FAILED at 88.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/http/tests/fetch/script-tests/stream-reader.js.rej

Patch:       LayoutTests/http/tests/fetch/script-tests/stream-reader.js
Index: LayoutTests/http/tests/fetch/script-tests/stream-reader.js
diff --git a/LayoutTests/http/tests/fetch/script-tests/stream-reader.js
b/LayoutTests/http/tests/fetch/script-tests/stream-reader.js
index
3a202716ac24c8779c5df5aca415bf5f26a7d152..dc1b094a8030507326f9a497a773139515eceb6c
100644
--- a/LayoutTests/http/tests/fetch/script-tests/stream-reader.js
+++ b/LayoutTests/http/tests/fetch/script-tests/stream-reader.js
@@ -88,4 +88,28 @@ promise_test(function(t) {
       });
   }, 'read contents with ExclusiveStreamReader');
 
+promise_test(function(t) {
+    return fetch('/fetch/resources/progressive.php').then(function(res) {
+        assert_false(res.bodyUsed);
+        var reader = res.body.getReader();
+        assert_true(res.bodyUsed);
+        return res;
+      }).then(function(res) {
+        return res.text();
+      }).then(unreached_rejection(t), function() {
+        // text() should fail because bodyUsed is set.
+      });
+  }, 'acquiring a reader should set bodyUsed.');
+
+promise_test(function(t) {
+    return fetch('/fetch/resources/progressive.php').then(function(res) {
+        // We need to access body attribute to start the stream.
+        res.body;
+        assert_false(res.bodyUsed);
+        res.text();
+        assert_true(res.bodyUsed);
+        assert_throws({name: 'TypeError'}, function() { res.body.getReader()
});
+      });
+  }, 'Setting bodyUsed means the body is locked.');
+
 done();

[commit-bot: I haz the power, 2015-02-23 03:54:45]

The CQ bit was unchecked by commit-bot@chromium.org

[yhirano, 2015-02-23 04:00:52]

New patchsets have been uploaded after l-g-t-m from horo@chromium.org

[yhirano, 2015-02-23 04:01:41]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2015-02-23 04:02:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/899653002/80001

[commit-bot: I haz the power, 2015-02-23 05:19:12]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190637