Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 899623002: Revert of Roll opus to opus-HEAD-66611f1. (Closed)

Created:
5 years, 10 months ago by henrika (OOO until Aug 14)
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll opus to opus-HEAD-66611f1. (patchset #3 id:40001 of https://codereview.chromium.org/865853005/) Reason for revert: This CL breaks WebRTC in Chrome since the new Opus version is not bit-exact with the previous version. Original issue's description: > Roll opus to opus-HEAD-66611f1. > > The third_party/opus/src CL is https://codereview.chromium.org/882843002. > > Support MIPS optimizations in opus. > > R=henrika@chromium.org,sergeyu@chromium.org > BUG=452984 > > Committed: https://crrev.com/ebbf54dafa1be134a4d45fc30c103388dfaa8ff0 > Cr-Commit-Position: refs/heads/master@{#313646} TBR=sergeyu@chromium.org,tlegrand@chromium.org,wtc@chromium.org BUG=452984 Committed: https://crrev.com/cd35af688438dfb0b31fff626cf0ff6ac52fd44f Cr-Commit-Position: refs/heads/master@{#314322}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -73 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/opus/BUILD.gn View 2 chunks +1 line, -31 lines 0 comments Download
M third_party/opus/README.chromium View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/opus/opus.gyp View 3 chunks +1 line, -18 lines 0 comments Download
D third_party/opus/opus_srcs_mips.gypi View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
henrika (OOO until Aug 14)
Created Revert of Roll opus to opus-HEAD-66611f1.
5 years, 10 months ago (2015-02-03 09:19:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899623002/1
5 years, 10 months ago (2015-02-03 09:20:33 UTC) #2
commit-bot: I haz the power
Failed to apply patch for third_party/opus/BUILD.gn: While running git apply --index -3 -p1; error: patch ...
5 years, 10 months ago (2015-02-03 09:21:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899623002/1
5 years, 10 months ago (2015-02-03 11:03:59 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 12:56:48 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 12:57:51 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd35af688438dfb0b31fff626cf0ff6ac52fd44f
Cr-Commit-Position: refs/heads/master@{#314322}

Powered by Google App Engine
This is Rietveld 408576698