Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 899603002: Files.app: Handles corner cases in NewMetadataProvider. (Closed)

Created:
5 years, 10 months ago by hirono
Modified:
5 years, 10 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Handles corner cases in NewMetadataProvider. The CL adds: * Assertion for property names passed to NewMetadataProvider. * Existance check for results obtained from getImpl. BUG=410766 TEST=FileManagerJsTest.NewMetadataProvider Committed: https://crrev.com/27ead8ef1d2f63980e803d3398713bde0d827aca Cr-Commit-Position: refs/heads/master@{#314297}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update test + add assertion. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -8 lines) Patch
M ui/file_manager/file_manager/foreground/js/metadata/new_metadata_provider.js View 1 5 chunks +30 lines, -7 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/new_metadata_provider_unittest.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/new_metadata_provider_unittest.js View 1 3 chunks +30 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
hirono
PTAL? Thanks!
5 years, 10 months ago (2015-02-03 06:00:05 UTC) #2
yawano
https://codereview.chromium.org/899603002/diff/1/ui/file_manager/file_manager/foreground/js/metadata/new_metadata_provider_unittest.js File ui/file_manager/file_manager/foreground/js/metadata/new_metadata_provider_unittest.js (right): https://codereview.chromium.org/899603002/diff/1/ui/file_manager/file_manager/foreground/js/metadata/new_metadata_provider_unittest.js#newcode132 ui/file_manager/file_manager/foreground/js/metadata/new_metadata_provider_unittest.js:132: var thrown = false; How about to use assertThrows? ...
5 years, 10 months ago (2015-02-03 08:19:47 UTC) #3
hirono
Sorry 1 revision was dropped from my previous CL. Please take another look? Thanks! https://codereview.chromium.org/899603002/diff/1/ui/file_manager/file_manager/foreground/js/metadata/new_metadata_provider_unittest.js ...
5 years, 10 months ago (2015-02-03 08:35:31 UTC) #4
yawano
lgtm.
5 years, 10 months ago (2015-02-03 08:38:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899603002/20001
5 years, 10 months ago (2015-02-03 09:04:31 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-03 09:29:03 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 09:33:29 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/27ead8ef1d2f63980e803d3398713bde0d827aca
Cr-Commit-Position: refs/heads/master@{#314297}

Powered by Google App Engine
This is Rietveld 408576698