Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 899583002: Revert of [Cast] Software encoder support for varying video frame sizes. (Closed)

Created:
5 years, 10 months ago by Lei Zhang
Modified:
5 years, 10 months ago
Reviewers:
hubbe, miu
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Cast] Software encoder support for varying video frame sizes. (patchset #3 id:60001 of https://codereview.chromium.org/877393003/) Reason for revert: Linux MSAN fails with uninit memory access. Original issue's description: > [Cast] Software encoder support for varying video frame sizes. > > Adds support for automatic on-line reconfiguration of the VP8 software > encoder whenever the video frame size changes. libvpx supports > shrinking frame sizes without tearing down the encoder, but growing > frames sizes still requires a full tear-down and re-creation. > > Most of this change involves adding extensive unit testing to confirm > media/cast is now capable of handling variable frames sizes end-to-end. > In addition, the cast_sender_app and cast_receiver_app diagnostic tools > have been updated. > > An upcoming change will eliminate the width and height properties from > media::cast::VideoSenderConfig, which are both being ignored now. > > BUG=451277 > > Committed: https://crrev.com/dbba1332d2d3c6d03d0e86f5dd72164b38b11442 > Cr-Commit-Position: refs/heads/master@{#314196} TBR=hubbe@chromium.org,miu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=451277 Committed: https://crrev.com/31bc0e862f93d2d020e2d0eb3b47e2b252e05ff8 Cr-Commit-Position: refs/heads/master@{#314246}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+370 lines, -585 lines) Patch
M media/cast/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M media/cast/cast.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M media/cast/receiver/video_decoder_unittest.cc View 6 chunks +13 lines, -50 lines 0 comments Download
M media/cast/sender/external_video_encoder.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/cast/sender/external_video_encoder.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M media/cast/sender/fake_software_video_encoder.h View 2 chunks +0 lines, -2 lines 0 comments Download
M media/cast/sender/fake_software_video_encoder.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M media/cast/sender/h264_vt_encoder.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/cast/sender/h264_vt_encoder.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M media/cast/sender/video_encoder.h View 1 chunk +0 lines, -4 lines 0 comments Download
M media/cast/sender/video_encoder_impl.h View 1 chunk +1 line, -3 lines 0 comments Download
M media/cast/sender/video_encoder_impl.cc View 3 chunks +1 line, -20 lines 0 comments Download
M media/cast/sender/video_encoder_impl_unittest.cc View 2 chunks +170 lines, -257 lines 0 comments Download
M media/cast/sender/video_sender.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M media/cast/sender/vp8_encoder.h View 3 chunks +5 lines, -13 lines 0 comments Download
M media/cast/sender/vp8_encoder.cc View 10 chunks +39 lines, -70 lines 0 comments Download
M media/cast/test/fake_media_source.h View 3 chunks +0 lines, -9 lines 0 comments Download
M media/cast/test/fake_media_source.cc View 9 chunks +38 lines, -54 lines 0 comments Download
M media/cast/test/linux_output_window.cc View 3 chunks +14 lines, -25 lines 0 comments Download
M media/cast/test/sender.cc View 7 chunks +70 lines, -37 lines 0 comments Download
M media/cast/test/simulator.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M media/cast/test/utility/video_utility.h View 1 chunk +1 line, -2 lines 0 comments Download
M media/cast/test/utility/video_utility.cc View 2 chunks +4 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
Created Revert of [Cast] Software encoder support for varying video frame sizes.
5 years, 10 months ago (2015-02-03 02:13:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899583002/1
5 years, 10 months ago (2015-02-03 02:15:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 02:16:39 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 02:17:38 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/31bc0e862f93d2d020e2d0eb3b47e2b252e05ff8
Cr-Commit-Position: refs/heads/master@{#314246}

Powered by Google App Engine
This is Rietveld 408576698