Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Issue 899553002: Make MockExtensionSystemFactory available in all ExtensionsTests. (Closed)

Created:
5 years, 10 months ago by Lei Zhang
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, babu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make MockExtensionSystemFactory available in all ExtensionsTests. BUG=454554 Committed: https://crrev.com/34f7ecae0b2246f952fd1700547a6e7c310db24e Cr-Commit-Position: refs/heads/master@{#314373}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M extensions/browser/api_unittest.h View 2 chunks +0 lines, -3 lines 0 comments Download
M extensions/browser/api_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/browser/extensions_test.h View 2 chunks +3 lines, -0 lines 0 comments Download
M extensions/browser/extensions_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Lei Zhang
Sending this out for review since James said " Your patch in #2 also seems ...
5 years, 10 months ago (2015-02-03 03:42:43 UTC) #2
James Cook
LGTM If you land this, in a follow-up CL could you change //extensions/browser/mojo/keep_alive_impl_unittest.cc so it ...
5 years, 10 months ago (2015-02-03 16:27:21 UTC) #3
Lei Zhang
On 2015/02/03 16:27:21, James Cook wrote: > LGTM > > If you land this, in ...
5 years, 10 months ago (2015-02-03 18:06:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899553002/1
5 years, 10 months ago (2015-02-03 18:06:41 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/40113)
5 years, 10 months ago (2015-02-03 18:11:10 UTC) #8
Lei Zhang
+rockot for OWNERS
5 years, 10 months ago (2015-02-03 18:14:48 UTC) #10
Ken Rockot(use gerrit already)
lgtm
5 years, 10 months ago (2015-02-03 18:33:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899553002/1
5 years, 10 months ago (2015-02-03 18:39:22 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 18:43:08 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 18:44:25 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34f7ecae0b2246f952fd1700547a6e7c310db24e
Cr-Commit-Position: refs/heads/master@{#314373}

Powered by Google App Engine
This is Rietveld 408576698