Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 899523005: - Return exit code 253 in case of API errors during loading. This (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/test_runner.dart
===================================================================
--- tools/testing/dart/test_runner.dart (revision 43502)
+++ tools/testing/dart/test_runner.dart (working copy)
@@ -943,8 +943,9 @@
}
bool get hasCrashed {
- // The Java dartc runner and dart2js exits with code 253 in case
- // of unhandled exceptions.
+ // dart2js exits with code 253 in case of unhandled exceptions.
+ // The dart binary exits with code 253 in case of an API error such
+ // as an invalid snapshot file.
ricow1 2015/02/05 14:00:42 dart2js exits with code 253 in case of a compiler
Ivan Posva 2015/02/05 14:26:24 Done.
if (exitCode == 253) return true;
if (io.Platform.operatingSystem == 'windows') {
// The VM uses std::abort to terminate on asserts.

Powered by Google App Engine
This is Rietveld 408576698