Move chrome.documentScan API to extensions/

Move chrome.documentScan API to extensions/.

Move the chrome.documentScan extension API from chrome/ to extensions/.

BUG=455695
Committed: https://crrev.com/dc80f4b7a1e17819a54b32a246f40766335cdff0
Cr-Commit-Position: refs/heads/master@{#315293}

[babu, 2015-02-05 13:23:08]

sudarsana.nagineni@intel.com changed reviewers:
+ jamescook@chromium.org, pstew@chromium.org, thestig@chromium.org,
yoz@chromium.org

[Lei Zhang, 2015-02-05 17:50:52]

chrome/ lgtm

[James Cook, 2015-02-05 19:02:59]

I'm OK with the move.

https://codereview.chromium.org/899523004/diff/1/extensions/browser/api/docum...
File extensions/browser/api/document_scan/document_scan_api.h (right):

https://codereview.chromium.org/899523004/diff/1/extensions/browser/api/docum...
extensions/browser/api/document_scan/document_scan_api.h:13: #ifndef
EXTENSIONS_BROWSER_API_DOCUMENT_SCAN_DOCUMENT_SCAN_API_H_
This is wrong. Move this to the top of the file, before #include <string>

https://codereview.chromium.org/899523004/diff/1/extensions/browser/api/docum...
File extensions/browser/api/document_scan/document_scan_api_unittest.cc (right):

https://codereview.chromium.org/899523004/diff/1/extensions/browser/api/docum...
extensions/browser/api/document_scan/document_scan_api_unittest.cc:4: #include
"extensions/browser/api/document_scan/document_scan_api.h"
nit: blank line above

https://codereview.chromium.org/899523004/diff/1/extensions/browser/api/docum...
File extensions/browser/api/document_scan/document_scan_interface.h (right):

https://codereview.chromium.org/899523004/diff/1/extensions/browser/api/docum...
extensions/browser/api/document_scan/document_scan_interface.h:11: #ifndef
EXTENSIONS_BROWSER_API_DOCUMENT_SCAN_DOCUMENT_SCAN_INTERFACE_H_
move to top of file

https://codereview.chromium.org/899523004/diff/1/extensions/browser/api/docum...
File extensions/browser/api/document_scan/mock_document_scan_interface.h
(right):

https://codereview.chromium.org/899523004/diff/1/extensions/browser/api/docum...
extensions/browser/api/document_scan/mock_document_scan_interface.h:1: //
Copyright 2014 The Chromium Authors. All rights reserved.
Is this file a strict move? If so you might need to use "git cl upload
--similarity=<lower number>" for it to recognize.

https://codereview.chromium.org/899523004/diff/1/extensions/extensions_tests.gyp
File extensions/extensions_tests.gyp (right):

https://codereview.chromium.org/899523004/diff/1/extensions/extensions_tests....
extensions/extensions_tests.gyp:170:
'browser/api/document_scan/document_scan_interface_chromeos_unittest.cc',
Either put this in the sources list above (I think there's a global filename
matching rule that makes this work), or better yet move
networking_config_service_chromeos_unittest.cc into this section.

[babu, 2015-02-05 20:21:38]

New patchsets have been uploaded after l-g-t-m from thestig@chromium.org

[Paul Stewart, 2015-02-05 21:31:08]

I'm alright with the move, lgtm as log as other things like documentation
continue to work.

[babu, 2015-02-05 21:34:03]

Thanks for reviewing!

https://codereview.chromium.org/899523004/diff/1/extensions/browser/api/docum...
File extensions/browser/api/document_scan/document_scan_api.h (right):

https://codereview.chromium.org/899523004/diff/1/extensions/browser/api/docum...
extensions/browser/api/document_scan/document_scan_api.h:13: #ifndef
EXTENSIONS_BROWSER_API_DOCUMENT_SCAN_DOCUMENT_SCAN_API_H_
On 2015/02/05 19:02:59, James Cook wrote:
> This is wrong. Move this to the top of the file, before #include <string>

Done.

https://codereview.chromium.org/899523004/diff/1/extensions/browser/api/docum...
File extensions/browser/api/document_scan/document_scan_api_unittest.cc (right):

https://codereview.chromium.org/899523004/diff/1/extensions/browser/api/docum...
extensions/browser/api/document_scan/document_scan_api_unittest.cc:4: #include
"extensions/browser/api/document_scan/document_scan_api.h"
On 2015/02/05 19:02:59, James Cook wrote:
> nit: blank line above

Done.

https://codereview.chromium.org/899523004/diff/1/extensions/browser/api/docum...
File extensions/browser/api/document_scan/document_scan_interface.h (right):

https://codereview.chromium.org/899523004/diff/1/extensions/browser/api/docum...
extensions/browser/api/document_scan/document_scan_interface.h:11: #ifndef
EXTENSIONS_BROWSER_API_DOCUMENT_SCAN_DOCUMENT_SCAN_INTERFACE_H_
On 2015/02/05 19:02:59, James Cook wrote:
> move to top of file

Done.

https://codereview.chromium.org/899523004/diff/1/extensions/browser/api/docum...
File extensions/browser/api/document_scan/mock_document_scan_interface.h
(right):

https://codereview.chromium.org/899523004/diff/1/extensions/browser/api/docum...
extensions/browser/api/document_scan/mock_document_scan_interface.h:1: //
Copyright 2014 The Chromium Authors. All rights reserved.
On 2015/02/05 19:02:59, James Cook wrote:
> Is this file a strict move? If so you might need to use "git cl upload
> --similarity=<lower number>" for it to recognize.

Done. Used 40.

https://codereview.chromium.org/899523004/diff/1/extensions/extensions_tests.gyp
File extensions/extensions_tests.gyp (right):

https://codereview.chromium.org/899523004/diff/1/extensions/extensions_tests....
extensions/extensions_tests.gyp:170:
'browser/api/document_scan/document_scan_interface_chromeos_unittest.cc',
On 2015/02/05 19:02:59, James Cook wrote:
> Either put this in the sources list above (I think there's a global filename
> matching rule that makes this work), or better yet move
> networking_config_service_chromeos_unittest.cc into this section.

Done. filename rules seems to be taking care the filtering based on filenames,
so moved this to the above sources list. Checked Linux and ChromeOS builds
locally.

[James Cook, 2015-02-05 23:09:42]

LGTM

[Yoyo Zhou, 2015-02-05 23:58:50]

LGTM

[babu, 2015-02-06 06:33:20]

sudarsana.nagineni@intel.com changed reviewers:
+ stevenjb@chromium.org

[babu, 2015-02-06 06:34:20]

sudarsana.nagineni@intel.com changed reviewers:
+ derat@chromium.org

[babu, 2015-02-06 06:35:16]

sudarsana.nagineni@intel.com changed reviewers:
- derat@chromium.org, stevenjb@chromium.org

[babu, 2015-02-06 08:50:47]

sudarsana.nagineni@intel.com changed reviewers:
+ stevenjb@chromium.org

[babu, 2015-02-06 08:51:57]

sudarsana.nagineni@intel.com changed reviewers:
- stevenjb@chromium.org

[babu, 2015-02-06 08:52:13]

The CQ bit was checked by sudarsana.nagineni@intel.com

[commit-bot: I haz the power, 2015-02-06 08:52:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/899523004/20001

[commit-bot: I haz the power, 2015-02-06 08:58:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-06 08:58:55]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Lei Zhang, 2015-02-06 09:04:38]

https://codereview.chromium.org/899523004/diff/20001/extensions/browser/api/d...
File extensions/browser/api/document_scan/DEPS (right):

https://codereview.chromium.org/899523004/diff/20001/extensions/browser/api/d...
extensions/browser/api/document_scan/DEPS:2: "+chromeos",
extensions/browser/DEPS already has this, so extensions/browser/api/*/DEPS don't
need this.

[babu, 2015-02-06 09:33:28]

New patchsets have been uploaded after l-g-t-m from
pstew@chromium.org,jamescook@chromium.org,yoz@chromium.org

[babu, 2015-02-06 09:46:17]

https://codereview.chromium.org/899523004/diff/20001/extensions/browser/api/d...
File extensions/browser/api/document_scan/DEPS (right):

https://codereview.chromium.org/899523004/diff/20001/extensions/browser/api/d...
extensions/browser/api/document_scan/DEPS:2: "+chromeos",
On 2015/02/06 09:04:38, Lei Zhang wrote:
> extensions/browser/DEPS already has this, so extensions/browser/api/*/DEPS
don't
> need this.

Acknowledged. Thanks!

[babu, 2015-02-09 09:03:05]

The CQ bit was checked by sudarsana.nagineni@intel.com

[commit-bot: I haz the power, 2015-02-09 09:03:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/899523004/40001

[commit-bot: I haz the power, 2015-02-09 11:04:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-09 11:04:24]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  ios_dbg_simulator on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
  ios_rel_device_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
  ios_rel_device_ninja_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)
Timed out jobs are not retried to avoid causing additional load on the builders
with large pending queues.

[babu, 2015-02-09 12:33:02]

The CQ bit was checked by sudarsana.nagineni@intel.com

[commit-bot: I haz the power, 2015-02-09 12:34:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/899523004/40001

[commit-bot: I haz the power, 2015-02-09 14:12:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-09 14:13:26]

Patchset 3 (id:??) landed as
https://crrev.com/dc80f4b7a1e17819a54b32a246f40766335cdff0
Cr-Commit-Position: refs/heads/master@{#315293}