Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1938)

Unified Diff: pkg/analysis_server/lib/src/get_handler.dart

Issue 899513003: Improve error reporting on status page (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/get_handler.dart
diff --git a/pkg/analysis_server/lib/src/get_handler.dart b/pkg/analysis_server/lib/src/get_handler.dart
index 4f9a1e2f153abc92266cb6dece72d845129f8143..eec283b6160377c16d5e091c905f5746695cb661 100644
--- a/pkg/analysis_server/lib/src/get_handler.dart
+++ b/pkg/analysis_server/lib/src/get_handler.dart
@@ -289,7 +289,14 @@ class GetHandler {
buffer.write('<p>null</p>');
return;
}
- ast.accept(new AstWriter(buffer));
+ AstWriter writer = new AstWriter(buffer);
+ ast.accept(writer);
+ if (writer.exceptions.isNotEmpty) {
+ buffer.write('<h3>Exceptions while creating page</h3>');
+ for (CaughtException exception in writer.exceptions) {
+ _writeException(buffer, exception);
+ }
+ }
});
});
}
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/status/ast_writer.dart » ('j') | pkg/analysis_server/lib/src/status/ast_writer.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698