tests/gclient_test.py - Issue 899503003: Add back detection of unreachable code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/gclient_test.py

Issue 899503003: Add back detection of unreachable code (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: use self.fail() instead Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/gclient_test.py

diff --git a/tests/gclient_test.py b/tests/gclient_test.py

index 2c7321a01575d485d032cbe41bd2792c4d6e9119..08a85f51cc87f5512788ee406d709dd32fba27d9 100755

--- a/tests/gclient_test.py

+++ b/tests/gclient_test.py

@@ -994,6 +994,7 @@ class GclientTest(trial_dir.TestCase):

obj = gclient.GClient.LoadCurrentConfig(options)

try:

obj.RunOnDeps('None', [])

+ self.fail("unreachable code")

M-A Ruel 2015/02/03 02:08:06 self.fail() is fine, it's unreachable code by defi

M-A Ruel 2015/02/03 20:40:51 I meant literally self.fail(), not self.fail("unre

wychen 2015/02/03 21:21:12 Done.

except gclient_utils.Error, e:

self.assertIn('allowed_hosts must be', str(e))

finally:

@@ -1018,6 +1019,7 @@ class GclientTest(trial_dir.TestCase):