Issue 8995021: ignore null value in proxy servers and bypass list capabilities

Issue 8995021: ignore null value in proxy servers and bypass list capabilities (Closed)

Created:
9 years ago by Huyen

Modified:
9 years ago

Reviewers:
kkania

CC:
chromium-reviews, kkania, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ignore null value in proxy servers and bypass list capabilities BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115065

Patch Set 2 : review #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -7 lines)			Patch
	M	chrome/test/webdriver/webdriver_capabilities_parser.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	chrome/test/webdriver/webdriver_capabilities_parser_unittest.cc	View	1	4 chunks	+48 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kkania

lgtm http://codereview.chromium.org/8995021/diff/1/chrome/test/webdriver/webdriver_capabilities_parser_unittest.cc File chrome/test/webdriver/webdriver_capabilities_parser_unittest.cc (right): http://codereview.chromium.org/8995021/diff/1/chrome/test/webdriver/webdriver_capabilities_parser_unittest.cc#newcode241 chrome/test/webdriver/webdriver_capabilities_parser_unittest.cc:241: caps.command.GetSwitchValueASCII(switches::kProxyBypassList).c_str()); EXPECT_FALSE(caps.command.HasSwitch...

9 years ago (2011-12-19 23:53:20 UTC) #2

Huyen

http://codereview.chromium.org/8995021/diff/1/chrome/test/webdriver/webdriver_capabilities_parser_unittest.cc File chrome/test/webdriver/webdriver_capabilities_parser_unittest.cc (right): http://codereview.chromium.org/8995021/diff/1/chrome/test/webdriver/webdriver_capabilities_parser_unittest.cc#newcode241 chrome/test/webdriver/webdriver_capabilities_parser_unittest.cc:241: caps.command.GetSwitchValueASCII(switches::kProxyBypassList).c_str()); On 2011/12/19 23:53:20, kkania wrote: > EXPECT_FALSE(caps.command.HasSwitch... Done.

9 years ago (2011-12-19 23:59:11 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hnguyen@chromium.org/8995021/3001

9 years ago (2011-12-20 00:00:05 UTC) #4

Change committed as 115065

Expand Messages | Collapse Messages