Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 899483004: Revert of Roll WebRTC 8220:8247, Libjingle 8221:8245 (Closed)

Created:
5 years, 10 months ago by ccameron
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll WebRTC 8220:8247, Libjingle 8221:8245 (patchset #1 id:1 of https://codereview.chromium.org/904633002/) Reason for revert: WebRTC failures on trunk: [15413:1287:0205/072819:11351253697224:ERROR:vt_video_decode_accelerator.cc(132)] Failed to create VTDecompressionSession: codecOpenErr (-8973) [15415:22019:0205/072820:11351625072101:FATAL:thread_posix.cc(101)] Check failed: thread_checker_.CalledOnValidThread(). 0 libbase.dylib base::debug::StackTrace::StackTrace() + 47 1 libbase.dylib base::debug::StackTrace::StackTrace() + 35 2 libbase.dylib logging::LogMessage::~LogMessage() + 70 3 libbase.dylib logging::LogMessage::~LogMessage() + 35 4 libcontent.dylib webrtc::ThreadPosix::Start(unsigned int&) + 252 5 libcontent.dylib webrtc::TraceImpl::TraceImpl() + 359 6 libcontent.dylib webrtc::TracePosix::TracePosix() + 42 7 libcontent.dylib webrtc::TracePosix::TracePosix() + 35 8 libcontent.dylib webrtc::TraceImpl::CreateInstance() + 46 9 libcontent.dylib webrtc::TraceImpl* webrtc::GetStaticInstance\u003Cwebrtc::TraceImpl>(webrtc::CountOperation) + 278 10 libcontent.dylib webrtc::TraceImpl::StaticInstance(webrtc::CountOperation, webrtc::TraceLevel) + 108 11 libcontent.dylib webrtc::Trace::CreateTrace() + 37 http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/2687/steps/content_browsertests%20on%20Mac-10.9/logs/WebRtcBrowserTest.CallAndVerifyVideoMutingWorks Original issue's description: > Roll WebRTC 8220:8247, Libjingle 8221:8245 > > WebRTC 8220:8247 > Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/cfe4b49..c24c0fb > > Libjingle 8221:8245 > Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/18f533d..b3a2c1e > > TBR=niklase > > Committed: https://crrev.com/8a73ddcc5a588be2b43797e72e21d33b07f29b71 > Cr-Commit-Position: refs/heads/master@{#314805} TBR=niklase@google.com,magjed@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/6ba18be1febf7eabf0d503e6898d1f28584bc4b5 Cr-Commit-Position: refs/heads/master@{#314825}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M DEPS View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/libjingle/README.chromium View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
ccameron
Created Revert of Roll WebRTC 8220:8247, Libjingle 8221:8245
5 years, 10 months ago (2015-02-05 16:31:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899483004/1
5 years, 10 months ago (2015-02-05 16:31:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 16:32:28 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6ba18be1febf7eabf0d503e6898d1f28584bc4b5 Cr-Commit-Position: refs/heads/master@{#314825}
5 years, 10 months ago (2015-02-05 16:33:18 UTC) #4
tommi (sloooow) - chröme
5 years, 10 months ago (2015-02-05 20:56:12 UTC) #5
Message was sent while issue was closed.
On 2015/02/05 16:33:18, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/6ba18be1febf7eabf0d503e6898d1f28584bc4b5
> Cr-Commit-Position: refs/heads/master@{#314825}

I took a look at the full log for content_browsertests and there's a whole lot
going on there:
http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29...

The first few failures seem to be in lock_impl_posix.cc(35) in Chrome, not
webrtc.  Any idea what's going on?

Powered by Google App Engine
This is Rietveld 408576698