Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1439)

Unified Diff: tests_lit/llvm2ice_tests/elf_container.ll

Issue 899483002: Subzero: Track protos + globals w/out initializers as undef too (not just helper funcs) (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: x Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests_lit/llvm2ice_tests/elf_container.ll
diff --git a/tests_lit/llvm2ice_tests/elf_container.ll b/tests_lit/llvm2ice_tests/elf_container.ll
index d8b6ad03ed181ef5c78169b4754fb9be5ce2e5b7..125be2ccf3c4408aceb5b8d4251805d3fbc2d434 100644
--- a/tests_lit/llvm2ice_tests/elf_container.ll
+++ b/tests_lit/llvm2ice_tests/elf_container.ll
@@ -21,6 +21,11 @@
declare void @llvm.memcpy.p0i8.p0i8.i32(i8*, i8*, i32, i32, i1)
declare void @llvm.memset.p0i8.i32(i8*, i8, i32, i32, i1)
+; Try other external functions (for cross tests).
+; Not testing external global variables since the NaCl bitcode writer
+; refuses to freeze such IR.
+declare void @external_foo(i32)
+
; Test some global data relocs (data, rodata, bss).
@bytes = internal global [7 x i8] c"ab\03\FF\F6fg", align 1
@bytes_const = internal constant [7 x i8] c"ab\03\FF\F6fg", align 1
@@ -97,6 +102,12 @@ define internal float @test_call_internal() {
ret float %f
}
+; Test calling an external function.
+define internal void @test_call_external() {
+ call void @external_foo(i32 42)
+ ret void
+}
+
; Test copying a function pointer, or a global data pointer.
define internal i32 @test_ret_fp() {
%r = ptrtoint float ()* @returnFloatConst to i32
@@ -387,6 +398,7 @@ define void @_start(i32) {
; CHECK: 0x34 R_386_32 .L$double$2 0x0
; CHECK: 0x{{.*}} R_386_PC32 memcpy
; CHECK: 0x{{.*}} R_386_PC32 memset
+; CHECK: 0x{{.*}} R_386_PC32 external_foo
; CHECK: }
; CHECK: Section ({{[0-9]+}}) .rel.data {
; The set of relocations between llvm-mc and the integrated elf-writer
@@ -614,6 +626,15 @@ define void @_start(i32) {
; CHECK-NEXT: Section: .text
; CHECK-NEXT: }
; CHECK: Symbol {
+; CHECK: Name: external_foo
+; CHECK-NEXT: Value: 0x0
+; CHECK-NEXT: Size: 0
+; CHECK-NEXT: Binding: Global
+; CHECK-NEXT: Type: None
+; CHECK-NEXT: Other: 0
+; CHECK-NEXT: Section: Undefined
+; CHECK-NEXT: }
+; CHECK: Symbol {
; CHECK: Name: memcpy
; CHECK-NEXT: Value: 0x0
; CHECK-NEXT: Size: 0

Powered by Google App Engine
This is Rietveld 408576698