Subzero: Track protos + globals w/out initializers as undef too (not just helper funcs)

Track protos + globals w/out initializers as undef too (not just helper funcs)

Also handle empty global variable lists -- and initialize
ShAddralign to 1 instead of 0, just in case. Previously
it would try to align by 0 when the variable list was empty.

This should help the crosstests pass with --elf.

BUG=none
R=kschimpf@google.com, stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=77973ccd79c922519bca276f4b62157fe52d5b43

[jvoung (off chromium), 2015-02-02 20:27:24]

jvoung@chromium.org changed reviewers:
+ kschimpf@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2015-02-02 21:57:26]

Crosstests run!!!1!

Otherwise lgtm assuming Karl agrees.

https://codereview.chromium.org/899483002/diff/40001/src/IceConverter.cpp
File src/IceConverter.cpp (right):

https://codereview.chromium.org/899483002/diff/40001/src/IceConverter.cpp#new...
src/IceConverter.cpp:124: llvm_unreachable("Unhandled GlobalDeclaration type");
report_fatal_error

https://codereview.chromium.org/899483002/diff/40001/src/IceELFObjectWriter.cpp
File src/IceELFObjectWriter.cpp (right):

https://codereview.chromium.org/899483002/diff/40001/src/IceELFObjectWriter.c...
src/IceELFObjectWriter.cpp:315: if (Vars.empty())
Move this to the top?  or at least above the IceString construction

[jvoung (off chromium), 2015-02-03 01:53:38]

https://codereview.chromium.org/899483002/diff/40001/src/IceConverter.cpp
File src/IceConverter.cpp (right):

https://codereview.chromium.org/899483002/diff/40001/src/IceConverter.cpp#new...
src/IceConverter.cpp:124: llvm_unreachable("Unhandled GlobalDeclaration type");
On 2015/02/02 21:57:26, stichnot wrote:
> report_fatal_error

Done.

https://codereview.chromium.org/899483002/diff/40001/src/IceELFObjectWriter.cpp
File src/IceELFObjectWriter.cpp (right):

https://codereview.chromium.org/899483002/diff/40001/src/IceELFObjectWriter.c...
src/IceELFObjectWriter.cpp:315: if (Vars.empty())
On 2015/02/02 21:57:26, stichnot wrote:
> Move this to the top?  or at least above the IceString construction

Done.

[Jim Stichnoth, 2015-02-03 17:53:20]

stichnot@chromium.org changed reviewers:
+ kschimpf@google.com
- kschimpf@chromium.org

[Karl, 2015-02-03 20:43:16]

lgtm

[jvoung (off chromium), 2015-02-03 20:48:44]

Committed patchset #5 (id:80001) manually as
77973ccd79c922519bca276f4b62157fe52d5b43 (presubmit successful).