Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 899473002: Fix a crash that MediaPlayerAndroid weak_ptr is incorrectly used across thread (Closed)

Created:
5 years, 10 months ago by qinmin
Modified:
5 years, 10 months ago
Reviewers:
xhwang
CC:
chromium-reviews, posciak+watch_chromium.org, wjia+watch_chromium.org, avayvod+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a crash that MediaPlayerAndroid weak_ptr is incorrectly used across thread For MediaPlayerListener, the callbacks can happen on a non-UI thread. Weak_ptr is not thread safe, so we shouldn't bind the weak_ptr in those callbacks. This change creates a threadsafe proxy class to bridge all the callbacks. BUG=453581, 447368, 447367 Committed: https://crrev.com/2e9885788692f69203a98fb42347428ef553d640 Cr-Commit-Position: refs/heads/master@{#314241}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -35 lines) Patch
M media/base/android/media_player_android.h View 3 chunks +10 lines, -12 lines 0 comments Download
M media/base/android/media_player_listener.h View 3 chunks +29 lines, -6 lines 0 comments Download
M media/base/android/media_player_listener.cc View 4 chunks +102 lines, -17 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
qinmin
PTAL
5 years, 10 months ago (2015-02-02 19:52:52 UTC) #2
xhwang
lgtm
5 years, 10 months ago (2015-02-02 20:53:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899473002/1
5 years, 10 months ago (2015-02-02 21:14:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 01:56:54 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2e9885788692f69203a98fb42347428ef553d640 Cr-Commit-Position: refs/heads/master@{#314241}
5 years, 10 months ago (2015-02-03 01:57:38 UTC) #7
qinmin
5 years, 10 months ago (2015-02-09 18:47:22 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/879273006/ by qinmin@chromium.org.

The reason for reverting is: this CL doesn't fix the original issue.

Powered by Google App Engine
This is Rietveld 408576698