Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1744)

Unified Diff: chrome/browser/extensions/bookmark_app_helper.h

Issue 899443002: Create bookmark apps at the end of the process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Hopefully last test Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/bookmark_app_helper.h
diff --git a/chrome/browser/extensions/bookmark_app_helper.h b/chrome/browser/extensions/bookmark_app_helper.h
index 31442a60d2b9ae426c1f4cb9c47ef356eaa1d2fe..835d94eca262ca41814b41eecc22e2055a7907bd 100644
--- a/chrome/browser/extensions/bookmark_app_helper.h
+++ b/chrome/browser/extensions/bookmark_app_helper.h
@@ -19,6 +19,7 @@
class ExtensionService;
class FaviconDownloader;
+class Profile;
class SkBitmap;
namespace content {
@@ -40,7 +41,7 @@ class BookmarkAppHelper : public content::NotificationObserver {
// install it to |service|. Icons will be downloaded from the URLs in
// |web_app_info.icons| using |contents| if |contents| is not NULL.
// All existing icons from WebApplicationInfo will also be used.
calamity 2015/02/03 07:29:49 Mention that the dialog will be created.
benwells 2015/02/03 08:54:13 Done.
- BookmarkAppHelper(ExtensionService* service,
+ BookmarkAppHelper(Profile* profile,
WebApplicationInfo web_app_info,
content::WebContents* contents);
~BookmarkAppHelper() override;
@@ -80,11 +81,23 @@ class BookmarkAppHelper : public content::NotificationObserver {
void OnIconsDownloaded(bool success,
const std::map<GURL, std::vector<SkBitmap> >& bitmaps);
+ // Called after the bubble has been shown, and the user has either accepted or
+ // the dialog was dismissed.
+ void OnBubbleCompleted(bool user_accepted,
+ const WebApplicationInfo& web_app_info);
+
+ // Called when the installation of the app is complete to perform the final
+ // installation steps.
+ void FinishInstallation(const Extension* extension);
+
// Overridden from content::NotificationObserver:
void Observe(int type,
const content::NotificationSource& source,
const content::NotificationDetails& details) override;
+ // The profile that the bookmark app is being added to.
+ Profile* profile_;
+
// The web contents that the bookmark app is being created for.
content::WebContents* contents_;

Powered by Google App Engine
This is Rietveld 408576698