chrome/browser/ui/views/frame/browser_view.h - Issue 899443002: Create bookmark apps at the end of the process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.h

Issue 899443002: Create bookmark apps at the end of the process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Feedback Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/frame/browser_view.h

diff --git a/chrome/browser/ui/views/frame/browser_view.h b/chrome/browser/ui/views/frame/browser_view.h

index 83bcf2ef9d920c9c5e39b1b933bc8bdbce7ff624..a85e479bd12b18442391c6724220b1c8e7c614dd 100644

--- a/chrome/browser/ui/views/frame/browser_view.h

+++ b/chrome/browser/ui/views/frame/browser_view.h

@@ -308,8 +308,9 @@ class BrowserView : public BrowserWindow,

Profile* profile) override;

void ShowUpdateChromeDialog() override;

void ShowBookmarkBubble(const GURL& url, bool already_bookmarked) override;

- void ShowBookmarkAppBubble(const WebApplicationInfo& web_app_info,

- const std::string& extension_id) override;

+ void ShowBookmarkAppBubble(

+ const WebApplicationInfo& web_app_info,

+ const ShowBookmarkAppBubbleCallback& callback) override;

void ShowTranslateBubble(content::WebContents* contents,

translate::TranslateStep step,

translate::TranslateErrors::Type error_type,