Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 899433008: DNS: Don't use forbidden non-const reference (Closed)

Created:
5 years, 10 months ago by Deprecated (see juliatuttle)
Modified:
5 years, 10 months ago
Reviewers:
davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DNS: Don't use forbidden non-const reference BUG= Committed: https://crrev.com/520d1ac60e430f5cc50d889babff86930ed4e955 Cr-Commit-Position: refs/heads/master@{#314474}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix mapped_ip too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M net/dns/dns_hosts.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Deprecated (see juliatuttle)
5 years, 10 months ago (2015-02-03 21:05:41 UTC) #2
davidben
https://codereview.chromium.org/899433008/diff/1/net/dns/dns_hosts.cc File net/dns/dns_hosts.cc (right): https://codereview.chromium.org/899433008/diff/1/net/dns/dns_hosts.cc#newcode158 net/dns/dns_hosts.cc:158: IPAddressNumber& mapped_ip = (*dns_hosts)[key]; There's another one here too. ...
5 years, 10 months ago (2015-02-03 21:20:32 UTC) #3
Deprecated (see juliatuttle)
PTAL, davidben. https://codereview.chromium.org/899433008/diff/1/net/dns/dns_hosts.cc File net/dns/dns_hosts.cc (right): https://codereview.chromium.org/899433008/diff/1/net/dns/dns_hosts.cc#newcode158 net/dns/dns_hosts.cc:158: IPAddressNumber& mapped_ip = (*dns_hosts)[key]; On 2015/02/03 21:20:32, ...
5 years, 10 months ago (2015-02-03 22:12:11 UTC) #4
davidben
lgtm
5 years, 10 months ago (2015-02-03 22:16:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899433008/20001
5 years, 10 months ago (2015-02-04 02:03:35 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-04 02:07:31 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 02:08:50 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/520d1ac60e430f5cc50d889babff86930ed4e955
Cr-Commit-Position: refs/heads/master@{#314474}

Powered by Google App Engine
This is Rietveld 408576698