Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 899413002: use a public url shortener (Closed)

Created:
5 years, 10 months ago by vapier
Modified:
5 years, 7 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

use a public url shortener The design doc pointed to is public on chromium.org, but the Googler-only shortener is not. Use a public one instead so anyone can follow it. BUG= Committed: https://crrev.com/943d5015c8b03566019c67962b5e22e028e2a75d Cr-Commit-Position: refs/heads/master@{#330325}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/common/extensions/api/image_writer_private.idl View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 17 (6 generated)
vapier
5 years, 10 months ago (2015-02-06 05:55:46 UTC) #2
vapier
5 years, 7 months ago (2015-05-16 10:16:13 UTC) #4
mtomasz
https://codereview.chromium.org/899413002/diff/1/chrome/common/extensions/api/image_writer_private.idl File chrome/common/extensions/api/image_writer_private.idl (right): https://codereview.chromium.org/899413002/diff/1/chrome/common/extensions/api/image_writer_private.idl#newcode9 chrome/common/extensions/api/image_writer_private.idl:9: // https://goo.gl/KzMEFq This url goes to omaha proxy.
5 years, 7 months ago (2015-05-18 00:09:09 UTC) #5
mtomasz
lgtm https://codereview.chromium.org/899413002/diff/1/chrome/common/extensions/api/image_writer_private.idl File chrome/common/extensions/api/image_writer_private.idl (right): https://codereview.chromium.org/899413002/diff/1/chrome/common/extensions/api/image_writer_private.idl#newcode9 chrome/common/extensions/api/image_writer_private.idl:9: // https://goo.gl/KzMEFq On 2015/05/18 00:09:09, mtomasz wrote: > ...
5 years, 7 months ago (2015-05-18 00:11:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899413002/1
5 years, 7 months ago (2015-05-18 01:46:03 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/64313)
5 years, 7 months ago (2015-05-18 01:51:59 UTC) #10
vapier
ugh i always forget about OWNERS in silly situations like this
5 years, 7 months ago (2015-05-18 01:58:08 UTC) #12
Mike West
LGTM.
5 years, 7 months ago (2015-05-18 03:49:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899413002/1
5 years, 7 months ago (2015-05-18 03:50:54 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 03:54:27 UTC) #16
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:33:29 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/943d5015c8b03566019c67962b5e22e028e2a75d
Cr-Commit-Position: refs/heads/master@{#330325}

Powered by Google App Engine
This is Rietveld 408576698