Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/libphonenumber/BUILD.gn

Issue 899403003: Linux: Enable ODR violation detection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: reference libphonenumber bug Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/config/compiler/BUILD.gn ('K') | « build/config/compiler/BUILD.gn ('k') | third_party/libphonenumber/libphonenumber.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libphonenumber/BUILD.gn
diff --git a/third_party/libphonenumber/BUILD.gn b/third_party/libphonenumber/BUILD.gn
index 4c32084ef42b63d77a567ab6036f0a0ba22f24a6..19214073ec5cf7007754c030383377bcb2bcd1ba 100644
--- a/third_party/libphonenumber/BUILD.gn
+++ b/third_party/libphonenumber/BUILD.gn
@@ -45,11 +45,6 @@ static_library("libphonenumber_without_metadata") {
"src/phonenumbers/utf/unilib.cc",
]
- # TODO(scottmg): Temporary until https://codereview.appspot.com/134650043/
- # lands and rolls. http://crbug.com/335824
- configs -= [ "//build/config/compiler:chromium_code" ]
- configs += [ "//build/config/compiler:no_chromium_code" ]
-
public_configs = [ ":libphonenumber_config" ]
public_deps = [
@@ -91,6 +86,9 @@ test("libphonenumber_unittests") {
"src/test/phonenumbers/unicodestring_test.cc",
]
+ # libphonenumber needs to fix their ODR violations. http://crbug.com/456021
+ configs += [ "//build/config/compiler:compiler_allow_odr_violations" ]
+
include_dirs = [ "src/test" ]
deps = [
« build/config/compiler/BUILD.gn ('K') | « build/config/compiler/BUILD.gn ('k') | third_party/libphonenumber/libphonenumber.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698