build/get_landmines.py - Issue 899403002: Upstream Enhanced Bookmark Model

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/get_landmines.py

Issue 899403002: Upstream Enhanced Bookmark Model (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/get_landmines.py

diff --git a/build/get_landmines.py b/build/get_landmines.py

index ac3d7d6008447751aed1902d00a4b5edef617aca..7a918c8662e3e1eeb26529d03ded6798a3eabd4c 100755

--- a/build/get_landmines.py

+++ b/build/get_landmines.py

@@ -29,6 +29,7 @@ def print_landmines():

print 'Need to clobber winja goma due to backend cwd cache fix.'

if platform() == 'android':

print 'Clobber: to handle new way of suppressing findbugs failures.'

+ print 'Clobber to fix gyp not rename package name (crbug.com/457038)'

if platform() == 'win' and builder() == 'ninja':

print 'Compile on cc_unittests fails due to symbols removed in r185063.'

if platform() == 'linux' and builder() == 'ninja':

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/EnhancedBookmarksBridge.java » ('j') | no next file with comments »