Chromium Code Reviews Chromium Code Reviews
Issue 899403002:
Upstream Enhanced Bookmark Model (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 #!/usr/bin/env python | 1 #!/usr/bin/env python |
| 2 # Copyright 2013 The Chromium Authors. All rights reserved. | 2 # Copyright 2013 The Chromium Authors. All rights reserved. |
| 3 # Use of this source code is governed by a BSD-style license that can be | 3 # Use of this source code is governed by a BSD-style license that can be |
| 4 # found in the LICENSE file. | 4 # found in the LICENSE file. |
| 5 | 5 |
| 6 """ | 6 """ |
| 7 This file emits the list of reasons why a particular build needs to be clobbered | 7 This file emits the list of reasons why a particular build needs to be clobbered |
| 8 (or a list of 'landmines'). | 8 (or a list of 'landmines'). |
| 9 """ | 9 """ |
| 10 | 10 |
| (...skipping 11 matching lines...) Expand all Loading... | |
| 22 | 22 |
| 23 def print_landmines(): | 23 def print_landmines(): |
| 24 """ | 24 """ |
| 25 ALL LANDMINES ARE EMITTED FROM HERE. | 25 ALL LANDMINES ARE EMITTED FROM HERE. |
| 26 """ | 26 """ |
| 27 if (distributor() == 'goma' and platform() == 'win32' and | 27 if (distributor() == 'goma' and platform() == 'win32' and |
| 28 builder() == 'ninja'): | 28 builder() == 'ninja'): |
| 29 print 'Need to clobber winja goma due to backend cwd cache fix.' | 29 print 'Need to clobber winja goma due to backend cwd cache fix.' |
| 30 if platform() == 'android': | 30 if platform() == 'android': |
| 31 print 'Clobber: to handle new way of suppressing findbugs failures.' | 31 print 'Clobber: to handle new way of suppressing findbugs failures.' |
| 32 print 'Clobber to fix gyp not rename package name (crbug.com/457038)' | |
| 32 if platform() == 'win' and builder() == 'ninja': | 33 if platform() == 'win' and builder() == 'ninja': |
| 33 print 'Compile on cc_unittests fails due to symbols removed in r185063.' | 34 print 'Compile on cc_unittests fails due to symbols removed in r185063.' |
| 34 if platform() == 'linux' and builder() == 'ninja': | 35 if platform() == 'linux' and builder() == 'ninja': |
| 35 print 'Builders switching from make to ninja will clobber on this.' | 36 print 'Builders switching from make to ninja will clobber on this.' |
| 36 if platform() == 'mac': | 37 if platform() == 'mac': |
| 37 print 'Switching from bundle to unbundled dylib (issue 14743002).' | 38 print 'Switching from bundle to unbundled dylib (issue 14743002).' |
| 38 if platform() in ('win', 'mac'): | 39 if platform() in ('win', 'mac'): |
| 39 print ('Improper dependency for create_nmf.py broke in r240802, ' | 40 print ('Improper dependency for create_nmf.py broke in r240802, ' |
| 40 'fixed in r240860.') | 41 'fixed in r240860.') |
| 41 if (platform() == 'win' and builder() == 'ninja' and | 42 if (platform() == 'win' and builder() == 'ninja' and |
| (...skipping 13 matching lines...) Expand all Loading... | |
| 55 print 'Clobber to rebuild GN files for V8' | 56 print 'Clobber to rebuild GN files for V8' |
| 56 print 'Clobber to get rid of stale generated mojom.h files' | 57 print 'Clobber to get rid of stale generated mojom.h files' |
| 57 print 'Need to clobber everything due to build_nexe change in nacl r13424' | 58 print 'Need to clobber everything due to build_nexe change in nacl r13424' |
| 58 print '[chromium-dev] PSA: clobber build needed for IDR_INSPECTOR_* compil...' | 59 print '[chromium-dev] PSA: clobber build needed for IDR_INSPECTOR_* compil...' |
| 59 print 'blink_resources.grd changed: crbug.com/400860' | 60 print 'blink_resources.grd changed: crbug.com/400860' |
| 60 print 'ninja dependency cycle: crbug.com/408192' | 61 print 'ninja dependency cycle: crbug.com/408192' |
| 61 print 'Clobber to fix missing NaCl gyp dependencies (crbug.com/427427).' | 62 print 'Clobber to fix missing NaCl gyp dependencies (crbug.com/427427).' |
| 62 print 'Another clobber for missing NaCl gyp deps (crbug.com/427427).' | 63 print 'Another clobber for missing NaCl gyp deps (crbug.com/427427).' |
| 63 print 'Clobber to fix GN not picking up increased ID range (crbug.com/444902)' | 64 print 'Clobber to fix GN not picking up increased ID range (crbug.com/444902)' |
| 64 | 65 |
| 65 | |
|
cjhopman
2015/02/12 01:17:16
nit: this blank line should stay ("Separate top-le
Ian Wen
2015/02/12 04:28:48
Done.
| |
| 66 def main(): | 66 def main(): |
| 67 print_landmines() | 67 print_landmines() |
| 68 return 0 | 68 return 0 |
| 69 | 69 |
| 70 | 70 |
| 71 if __name__ == '__main__': | 71 if __name__ == '__main__': |
| 72 sys.exit(main()) | 72 sys.exit(main()) |
| OLD | NEW |
