Allow eval and arguments as property names

Allow eval and arguments as property names

We incorrectly disallowed eval and arguments in accessor and method
names. This was because we checked the name inside the
ParseFunctionLiteral. We now flag accessors so that lazy parsing of
these functions are treated correctly.

BUG=v8:1984
R=adamk, dslomov@chromium.org
LOG=N

Committed: https://crrev.com/64abe65210adde13cb83aa0d3e747babd9979da8
Cr-Commit-Position: refs/heads/master@{#26497}

[arv (Not doing code reviews), 2015-02-06 00:00:44]

expand test

[arv (Not doing code reviews), 2015-02-06 00:03:55]

PTAL

https://codereview.chromium.org/899363002/diff/20001/src/preparser.cc
File src/preparser.cc (right):

https://codereview.chromium.org/899363002/diff/20001/src/preparser.cc#newcode949
src/preparser.cc:949: CheckStrictFunctionParameters(eval_args_error_loc,
dupe_error_loc,
Another option might be to pass in language_mode(), kind, is_rest to
CheckStrictFunctionNameAndParameters.

[adamk, 2015-02-06 00:23:58]

https://codereview.chromium.org/899363002/diff/20001/src/preparser.cc
File src/preparser.cc (right):

https://codereview.chromium.org/899363002/diff/20001/src/preparser.cc#newcode949
src/preparser.cc:949: CheckStrictFunctionParameters(eval_args_error_loc,
dupe_error_loc,
On 2015/02/06 00:03:55, arv wrote:
> Another option might be to pass in language_mode(), kind, is_rest to
> CheckStrictFunctionNameAndParameters.

Yeah, I think that's a better move than having to duplicate both the
check_params and check_name logic in the parser and preparser.

[arv (Not doing code reviews), 2015-02-06 17:00:03]

Cleanup based on code review

[arv (Not doing code reviews), 2015-02-06 17:03:34]

PTAL

There is some cleanup opportunities with how arrow functions checks their
paramaters but I thought I'd do that in another CL.

[adamk, 2015-02-06 17:11:40]

lgtm

[arv (Not doing code reviews), 2015-02-06 17:40:42]

The CQ bit was checked by arv@chromium.org

[commit-bot: I haz the power, 2015-02-06 17:41:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/899363002/40001

[commit-bot: I haz the power, 2015-02-06 18:04:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-06 18:04:33]

Patchset 3 (id:??) landed as
https://crrev.com/64abe65210adde13cb83aa0d3e747babd9979da8
Cr-Commit-Position: refs/heads/master@{#26497}