Issue 899353002: Unregister GCMInvalidationBridge from GCMDriver when user signs out.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 899353002: Unregister GCMInvalidationBridge from GCMDriver when user signs out. (Closed)

Created:
5 years, 10 months ago by pavely

Modified:
5 years, 10 months ago

Reviewers:
jianli

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Unregister GCMInvalidationBridge from GCMDriver when user signs out. Currently when user signs out GCMInvalidationBridge stays registered with GCMDriver preventing it from shutting down. GCMInvalidationBridge needs to unregister when user signs out. BUG=446349 R=jianli@chromium.org Committed: https://crrev.com/f0fdb821b503ddaf455fd986c516e9b07a2e500a Cr-Commit-Position: refs/heads/master@{#315103}

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -1 line)			Patch
M	components/invalidation/gcm_invalidation_bridge.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	components/invalidation/gcm_invalidation_bridge.cc	View	2 chunks	+17 lines, -1 line	0 comments	Download
M	components/invalidation/ticl_invalidation_service.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899353002/1

5 years, 10 months ago (2015-02-06 19:41:58 UTC) #4

commit-bot: I haz the power

5 years, 10 months ago (2015-02-06 20:53:35 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/f0fdb821b503ddaf455fd986c516e9b07a2e500a
Cr-Commit-Position: refs/heads/master@{#315103}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages