Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 899313002: Show thumbnail on list view only when the file is image or video. (Closed)

Created:
5 years, 10 months ago by fukino
Modified:
5 years, 10 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show thumbnail on list view only when the file is image or video. BUG=402344 TEST=Check that Google doc files don't have thumbnails on list view. Committed: https://crrev.com/6b8c52f47d8b93bc3f63cf57770fc67ab88fd6d0 Cr-Commit-Position: refs/heads/master@{#314994}

Patch Set 1 #

Total comments: 2

Patch Set 2 : isAudio -> isVideo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ui/file_manager/file_manager/foreground/js/ui/file_table.js View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
fukino
PTAL. Sorry for requesting multiple reviews. Thanks!
5 years, 10 months ago (2015-02-05 18:59:05 UTC) #2
yawano
https://codereview.chromium.org/899313002/diff/1/ui/file_manager/file_manager/foreground/js/ui/file_table.js File ui/file_manager/file_manager/foreground/js/ui/file_table.js (right): https://codereview.chromium.org/899313002/diff/1/ui/file_manager/file_manager/foreground/js/ui/file_table.js#newcode478 ui/file_manager/file_manager/foreground/js/ui/file_table.js:478: if (FileType.isImage(entry) || FileType.isAudio(entry)) FileType.isAudio -> FileType.isVideo?
5 years, 10 months ago (2015-02-06 02:17:43 UTC) #3
fukino
https://codereview.chromium.org/899313002/diff/1/ui/file_manager/file_manager/foreground/js/ui/file_table.js File ui/file_manager/file_manager/foreground/js/ui/file_table.js (right): https://codereview.chromium.org/899313002/diff/1/ui/file_manager/file_manager/foreground/js/ui/file_table.js#newcode478 ui/file_manager/file_manager/foreground/js/ui/file_table.js:478: if (FileType.isImage(entry) || FileType.isAudio(entry)) On 2015/02/06 02:17:43, yawano wrote: ...
5 years, 10 months ago (2015-02-06 06:52:04 UTC) #4
yawano
lgtm. Thank you!
5 years, 10 months ago (2015-02-06 06:53:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899313002/20001
5 years, 10 months ago (2015-02-06 06:54:53 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-06 07:20:50 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 07:22:09 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/6b8c52f47d8b93bc3f63cf57770fc67ab88fd6d0
Cr-Commit-Position: refs/heads/master@{#314994}

Powered by Google App Engine
This is Rietveld 408576698