Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 899303002: Fix dart warnings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/src/elements/general_error.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index 564914e8689aa0f49cfbf5dd0ee270f04add4fde..f4ec057dd8637c9db7649e179c194b4e17ef074f 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -282,9 +282,8 @@ abstract class ServiceObject extends Observable {
abstract class Coverage {
// Following getters and functions will be provided by [ServiceObject].
- ServiceObjectOwner get owner;
- String get type;
- VM get vm;
+ String get id;
+ Isolate get isolate;
/// Default handler for coverage data.
void processCoverageData(List coverageData) {
@@ -301,8 +300,7 @@ abstract class Coverage {
}
return isolate.invokeRpcNoUpgrade('getCoverage', params).then(
(ObservableMap map) {
- var coverageOwner = (type == 'Isolate') ? this : owner;
- var coverage = new ServiceObject._fromMap(coverageOwner, map);
+ var coverage = new ServiceObject._fromMap(isolate, map);
assert(coverage.type == 'CodeCoverage');
var coverageList = coverage['coverage'];
assert(coverageList != null);
« no previous file with comments | « runtime/observatory/lib/src/elements/general_error.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698