Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 899293002: Fix inconsistent LengthMode definition for 'textLength' (Closed)

Created:
5 years, 10 months ago by fs
Modified:
5 years, 10 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, rwlbuis, fs, kouhei+svg_chromium.org, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Steve Block, pdr+svgwatchlist_chromium.org, Eric Willigers
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix inconsistent LengthMode definition for 'textLength' The 'textLength' attribute on SVGTextContentElement was defined as LengthModeOther, while the lengthModeForAnimatedLengthAttribute table defined as LengthModeWidth. Use the latter in both cases instead. BUG=455737 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189707

Patch Set 1 #

Patch Set 2 : A newline too far. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
A LayoutTests/svg/animations/animate-textlength-unitmode.html View 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/svg/animations/animate-textlength-unitmode-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGTextContentElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
fs
5 years, 10 months ago (2015-02-06 09:02:24 UTC) #2
Erik Dahlström (inactive)
LGTM
5 years, 10 months ago (2015-02-06 09:11:52 UTC) #3
kouhei (in TOK)
lgtm
5 years, 10 months ago (2015-02-06 10:59:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899293002/20001
5 years, 10 months ago (2015-02-06 11:58:13 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=189637
5 years, 10 months ago (2015-02-06 12:39:46 UTC) #7
fs
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/904043002/ by fs@opera.com. ...
5 years, 10 months ago (2015-02-06 15:04:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899293002/20001
5 years, 10 months ago (2015-02-06 23:13:25 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 23:14:15 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189707

Powered by Google App Engine
This is Rietveld 408576698