Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Issue 899283004: Remove pinch zoom handling from the browser process (Closed)

Created:
5 years, 10 months ago by ccameron
Modified:
5 years, 10 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove pinch zoom handling from the browser process Pinch zoom is done by the renderer process now. Note that this leaves the PreHandleGestureEvent in place, as most if not all instances of it preventing gesture events are still desirable with the new pinch zoom behavior. BUG=451559 Committed: https://crrev.com/4907e06114a13ef908846f43b8332938c2d5f47f Cr-Commit-Position: refs/heads/master@{#314925}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -112 lines) Patch
M content/browser/renderer_host/render_widget_host_delegate.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_delegate.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 2 chunks +0 lines, -6 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +0 lines, -42 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 1 chunk +0 lines, -50 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ccameron
Entrails of the pinch change.
5 years, 10 months ago (2015-02-05 23:32:50 UTC) #2
Avi (use Gerrit)
lgtm
5 years, 10 months ago (2015-02-05 23:40:42 UTC) #3
ccameron
Thanks!
5 years, 10 months ago (2015-02-05 23:44:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899283004/1
5 years, 10 months ago (2015-02-05 23:45:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 00:39:54 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 00:40:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4907e06114a13ef908846f43b8332938c2d5f47f
Cr-Commit-Position: refs/heads/master@{#314925}

Powered by Google App Engine
This is Rietveld 408576698