Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 899243002: Make standalone tests not dependent on current working directory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index b29c3f0130e55a515e1cd325aae668d5470c4bdf..95270b282363b26b4ffac62753e5ca6da5812d6b 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -207,7 +207,6 @@ abstract class TestSuite {
? '$buildDir/dart-sdk/bin/dart$suffix'
: '$buildDir/dart$suffix';
}
-
Ivan Posva 2015/02/05 14:46:20 ?
ricow1 2015/02/05 15:08:34 removed
TestUtils.ensureExists(dartExecutable, configuration);
return dartExecutable;
}
@@ -1551,17 +1550,8 @@ class StandardTestSuite extends TestSuite {
List<String> dartOptions = optionsFromFile["dartOptions"];
assert(!isMultitest || dartOptions == null);
- if (dartOptions == null) {
- args.add(filePath.toNativePath());
- } else {
- var executable_name = dartOptions[0];
- // TODO(ager): Get rid of this hack when the runtime checkout goes away.
- var file = new File(executable_name);
- if (!file.existsSync()) {
- executable_name = '../$executable_name';
- assert(new File(executable_name).existsSync());
- dartOptions[0] = executable_name;
- }
+ args.add(filePath.toNativePath());
+ if (dartOptions != null) {
args.addAll(dartOptions);
}

Powered by Google App Engine
This is Rietveld 408576698