Fix double lock of texture resource in software renderer

cc/trees/layer_tree_host_pixeltest_readback.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "build/build_config.h"
 #include "cc/layers/solid_color_layer.h"
 #include "cc/layers/texture_layer.h"
 #include "cc/output/copy_output_request.h"
 #include "cc/output/copy_output_result.h"
 #include "cc/test/fake_picture_layer.h"
@@ skipping 1126 matching lines @@
   green->AddChild(blue);
 
   RunReadbackTestWithReadbackTarget(
       PIXEL_TEST_GL,
       READBACK_DEFAULT,
       background,
       green.get(),
       base::FilePath(FILE_PATH_LITERAL("green_with_blue_corner.png")));
 }
 
+class LTHReadbackNonFirstNonRootRenderPassTest

[danakj, 2015/02/06 23:11:42]

Sorry LTH I meant LayerTreeHost, but was saving typing heh :)

+    : public LayerTreeHostReadbackPixelTest,
+      public testing::WithParamInterface<bool> {};
+
+TEST_P(LTHReadbackNonFirstNonRootRenderPassTest,
+       ReadbackNonRootOrFirstLayer) {
+  // This test has 3 render passes with the copy request

[danakj, 2015/02/06 23:11:43]

Wrap this comment at 80 columns instead of at 60 or so?

+  // on the renderpass in the middle. Doing a copy request

[danakj, 2015/02/06 23:11:42]

"RenderPass" or "render pass", not "renderpass"

+  // can be destructive of state, so for renderpasses after

[danakj, 2015/02/06 23:11:42]

ditto

+  // the first drawn the code path is different.
+  // This verifies the non - first and non - root path.

[danakj, 2015/02/06 23:11:42]

no spaces around -

+  // See http://crbug.com/99393 for more information.
+  scoped_refptr<SolidColorLayer> background =
+      CreateSolidColorLayer(gfx::Rect(200, 200), SK_ColorGREEN);
+  background->SetForceRenderSurface(true);

[danakj, 2015/02/06 23:11:42]

do these SetForceRS calls actually do anything for this test? layers with a copy
request get a render surface. If you remove them does the test fail without the
change and pass with it still?

+
+  scoped_refptr<SolidColorLayer> blue =
+      CreateSolidColorLayer(gfx::Rect(150, 150, 50, 50), SK_ColorBLUE);
+  blue->SetForceRenderSurface(true);

[danakj, 2015/02/06 23:11:43]

same here?

+  blue->RequestCopyOfOutput(CopyOutputRequest::CreateBitmapRequest(
+      base::Bind(&IgnoreReadbackResult)));
+  background->AddChild(blue);
+
+  RunReadbackTestWithReadbackTarget(
+      GetParam() ? PIXEL_TEST_GL : PIXEL_TEST_SOFTWARE,
+      READBACK_DEFAULT,
+      background,
+      background.get(),
+      base::FilePath(FILE_PATH_LITERAL("green_with_blue_corner.png")));
+}
+
+INSTANTIATE_TEST_CASE_P(LTHReadbackNonFirstNonRootRenderPassTests,
+                        LTHReadbackNonFirstNonRootRenderPassTest,
+                        testing::Bool());
+
 }  // namespace
 }  // namespace cc
 
 #endif  // OS_ANDROID