Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1056)

Unified Diff: chrome/browser/ui/webui/ntp/ntp_resource_cache.cc

Issue 899173002: Replace Webstore link with app info dialog link in chrome://apps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reformat Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
diff --git a/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc b/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
index e9e624d650ef1cb20896be8139730ad242a55eab..fa9769bc5d1f035e03a8dd792489a398ffaefeab 100644
--- a/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
+++ b/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
@@ -159,6 +159,14 @@ std::string GetNewTabBackgroundTilingCSS(
return ThemeProperties::TilingToString(repeat_mode);
}
+bool ShouldDisplayAppInfoDialog() {
+#if defined(OS_MACOSX)
+ return false;
+#else
+ return true;
+#endif
+}
+
} // namespace
NTPResourceCache::NTPResourceCache(Profile* profile)
@@ -439,6 +447,8 @@ void NTPResourceCache::CreateNewTabHTML() {
l10n_util::GetStringUTF16(IDS_NEW_TAB_APP_OPTIONS));
load_time_data.SetString("appdetails",
l10n_util::GetStringUTF16(IDS_NEW_TAB_APP_DETAILS));
+ load_time_data.SetString("appinfodialog",
+ l10n_util::GetStringUTF16(IDS_APP_CONTEXT_MENU_SHOW_INFO));
load_time_data.SetString("appcreateshortcut",
l10n_util::GetStringUTF16(IDS_NEW_TAB_APP_CREATE_SHORTCUT));
load_time_data.SetString("appDefaultPageName",
@@ -502,6 +512,9 @@ void NTPResourceCache::CreateNewTabHTML() {
bool bookmark_apps_enabled = extensions::util::IsNewBookmarkAppsEnabled();
load_time_data.SetBoolean("enableNewBookmarkApps", bookmark_apps_enabled);
+ load_time_data.SetBoolean("canShowAppInfoDialog",
+ ShouldDisplayAppInfoDialog());
+
#if defined(OS_CHROMEOS)
load_time_data.SetString("expandMenu",
l10n_util::GetStringUTF16(IDS_NEW_TAB_CLOSE_MENU_EXPAND));

Powered by Google App Engine
This is Rietveld 408576698