chrome/browser/ui/cocoa/apps/app_info_dialog_cocoa.mm - Issue 899173002: Replace Webstore link with app info dialog link in chrome://apps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/apps/app_info_dialog_cocoa.mm

Issue 899173002: Replace Webstore link with app info dialog link in chrome://apps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Implement mac AppInfoDialog methods Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/apps/app_info_dialog.h ('K') | « chrome/browser/ui/apps/app_info_dialog.h ('k') | chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/apps/app_info_dialog_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/apps/app_info_dialog_cocoa.mm b/chrome/browser/ui/cocoa/apps/app_info_dialog_cocoa.mm

index 33a8aa235120bbefbf0048029e0df6d2a6435e8e..17df650e5ce058d7b0d44ba4bbe5e5f210334134 100644

--- a/chrome/browser/ui/cocoa/apps/app_info_dialog_cocoa.mm

+++ b/chrome/browser/ui/cocoa/apps/app_info_dialog_cocoa.mm

@@ -5,6 +5,14 @@

#include "base/logging.h"

#include "chrome/browser/ui/apps/app_info_dialog.h"

+bool CanShowAppInfoDialog() {

+ return false;

+gfx::Size GetAppInfoNativeDialogSize() {

+ NOTIMPLEMENTED();

tapted 2015/02/18 05:22:09 return gfx::Size(); You'll also need #include "u

void ShowAppInfoInAppList(gfx::NativeWindow parent,

const gfx::Rect& app_list_bounds,

Profile* profile,