Replace Webstore link with app info dialog link in chrome://apps

chrome/browser/ui/webui/extensions/extension_settings_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/extensions/extension_settings_handler.h"
 
 #include "apps/app_load_service.h"
 #include "apps/saved_files_service.h"
 #include "base/auto_reset.h"
 #include "base/base64.h"
@@ skipping 95 matching lines @@
 using base::DictionaryValue;
 using base::ListValue;
 using content::RenderViewHost;
 using content::WebContents;
 
 namespace {
 
 const char kAppsDeveloperToolsExtensionId[] =
     "ohmmkhmmmpcnpikjeljgnaoabkaalbgc";
 
-// Returns true if the extensions page should display the new-style extension
-// info dialog. If false, display the old permissions dialog.
-bool ShouldDisplayExtensionInfoDialog() {
-#if defined(OS_MACOSX)
-  return false;
-#else
-  return true;
-#endif
-}
-
 }  // namespace
 
 namespace extensions {
 
 ExtensionPage::ExtensionPage(const GURL& url,
                              int render_process_id,
                              int render_view_id,
                              bool incognito,
                              bool generated_background_page)
     : url(url),
@@ skipping 172 matching lines @@
       Manifest::IsUnpackedLocation(extension->location()));
   extension_data->SetBoolean("is_hosted_app", extension->is_hosted_app());
   extension_data->SetBoolean("is_platform_app", extension->is_platform_app());
   extension_data->SetBoolean("homepageProvided",
       ManifestURL::SpecifiedHomepageURL(extension));
   extension_data->SetBoolean("optionsOpenInTab",
                              OptionsPageInfo::ShouldOpenInTab(extension));
   extension_data->SetString("optionsPageHref",
                             OptionsPageInfo::GetOptionsPage(extension).spec());
   extension_data->SetBoolean("enableExtensionInfoDialog",
-                             ShouldDisplayExtensionInfoDialog());
+                             CanShowAppInfoDialog());
 
   // Add dependent extensions.
   base::ListValue* dependents_list = new base::ListValue;
   if (extension->is_shared_module()) {
     scoped_ptr<ExtensionSet> dependent_extensions =
         extension_service_->shared_module_service()->GetDependentExtensions(
             extension);
     for (ExtensionSet::const_iterator i = dependent_extensions->begin();
          i != dependent_extensions->end();
          i++) {
@@ skipping 236 matching lines @@
   source->AddString("extensionSettingsReloadTerminated",
       l10n_util::GetStringUTF16(IDS_EXTENSIONS_RELOAD_TERMINATED));
   source->AddString("extensionSettingsRepairCorrupted",
       l10n_util::GetStringUTF16(IDS_EXTENSIONS_REPAIR_CORRUPTED));
   source->AddString("extensionSettingsLaunch",
       l10n_util::GetStringUTF16(IDS_EXTENSIONS_LAUNCH));
   source->AddString("extensionSettingsReloadUnpacked",
       l10n_util::GetStringUTF16(IDS_EXTENSIONS_RELOAD_UNPACKED));
   source->AddString("extensionSettingsOptions",
       l10n_util::GetStringUTF16(IDS_EXTENSIONS_OPTIONS_LINK));
-  if (ShouldDisplayExtensionInfoDialog()) {
+  if (CanShowAppInfoDialog()) {
     source->AddString("extensionSettingsPermissions",
                       l10n_util::GetStringUTF16(IDS_EXTENSIONS_INFO_LINK));
   } else {
     source->AddString(
         "extensionSettingsPermissions",
         l10n_util::GetStringUTF16(IDS_EXTENSIONS_PERMISSIONS_LINK));
   }
   source->AddString("extensionSettingsVisitWebsite",
       l10n_util::GetStringUTF16(IDS_EXTENSIONS_VISIT_WEBSITE));
   source->AddString("extensionSettingsVisitWebStore",
@@ skipping 648 matching lines @@
 
   if (!extension_id_prompting_.empty())
     return;  // Only one prompt at a time.
   extension_id_prompting_ = extension->id();
 
   // The BrokerDelegate manages its own lifetime.
   BrokerDelegate* broker_delegate = new BrokerDelegate(AsWeakPtr());
 
   // Show the new-style extensions dialog when the flag is set. The flag cannot
   // be set on Mac platforms.
-  if (ShouldDisplayExtensionInfoDialog()) {
+  if (CanShowAppInfoDialog()) {
     UMA_HISTOGRAM_ENUMERATION("Apps.AppInfoDialog.Launches",
                               AppInfoLaunchSource::FROM_EXTENSIONS_PAGE,
                               AppInfoLaunchSource::NUM_LAUNCH_SOURCES);
 
     // Display the dialog at a size similar to the app list.
-    const int kAppInfoDialogWidth = 380;
-    const int kAppInfoDialogHeight = 490;
-
     ShowAppInfoInNativeDialog(
         web_contents()->GetTopLevelNativeWindow(),
-        gfx::Size(kAppInfoDialogWidth, kAppInfoDialogHeight),
+        GetAppInfoNativeDialogSize(),
         Profile::FromWebUI(web_ui()), extension,
         base::Bind(&BrokerDelegate::AppInfoDialogClosed,
                    base::Unretained(broker_delegate)));
   } else {
     prompt_.reset(new ExtensionInstallPrompt(web_contents()));
     std::vector<base::FilePath> retained_file_paths;
     if (extension->permissions_data()->HasAPIPermission(
             APIPermission::kFileSystem)) {
       std::vector<apps::SavedFileEntry> retained_file_entries =
           apps::SavedFilesService::Get(Profile::FromWebUI(web_ui()))
@@ skipping 265 matching lines @@
     extension_service_->EnableExtension(extension_id);
   } else {
     ExtensionErrorReporter::GetInstance()->ReportError(
         base::UTF8ToUTF16(JoinString(requirement_errors, ' ')),
         true);  // Be noisy.
   }
   requirements_checker_.reset();
 }
 
 }  // namespace extensions