Replace Webstore link with app info dialog link in chrome://apps

chrome/browser/ui/apps/app_info_dialog.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_APPS_APP_INFO_DIALOG_H_
 #define CHROME_BROWSER_UI_APPS_APP_INFO_DIALOG_H_
 
 #include "base/callback_forward.h"
 #include "ui/gfx/native_widget_types.h"
 
 class Profile;
 
 namespace extensions {
 class Extension;
 }
 
 namespace gfx {
 class Rect;
 class Size;
 }
 
 // Used for UMA to track where the App Info dialog is launched from.
 enum AppInfoLaunchSource {
   FROM_APP_LIST,         // Launched from the app list context menu.
   FROM_EXTENSIONS_PAGE,  // Launched from the chrome://extensions page.

[sashab, 2015/02/09 11:47:07]

Almost forgot! We'll need a new Launch Source for launching from the apps page,
and the UMA to record it :) Also remember to update histograms.xml.

   NUM_LAUNCH_SOURCES,
 };
 
+// Size of native window container for app info dialog

[sashab, 2015/02/09 11:47:07]

Nit: . at end of comment. Also sentence tense: "Returns the size of..."

+gfx::Size GetAppInfoNativeDialogSize();
+

[sashab, 2015/02/09 11:47:08]

I'd be happy to put ShouldShowAppInfoDialog here. If you wanted to be really
fancy, you could have ShouldShowAppInfoDialog(AppInfoLaunchSource), which varies
depending on the source.

Although, I'm pretty sure this function will just be if (mac) return false, else
return true? If so its independent of the launch source - we can come back and
add that in once it varies depending on where we're launching from. So we could
even do something like...
// Whether or not the app info dialog can be shown on this platform.
bool CanShowAppInfoDialogOnPlatform();

 // Shows the chrome app information as a frameless window for the given |app|
 // and |profile| at the given |app_list_bounds|. Appears 'inside' the app list.
 void ShowAppInfoInAppList(gfx::NativeWindow parent,
                           const gfx::Rect& app_list_bounds,
                           Profile* profile,
                           const extensions::Extension* app,
                           const base::Closure& close_callback);
 
 // Shows the chrome app information in a native dialog box of the given |size|.
 void ShowAppInfoInNativeDialog(gfx::NativeWindow parent,
                                const gfx::Size& size,
                                Profile* profile,
                                const extensions::Extension* app,
                                const base::Closure& close_callback);
 
 #endif  // CHROME_BROWSER_UI_APPS_APP_INFO_DIALOG_H_