extension: fix typo that breaks showing extension options dialog.

chrome/browser/ui/webui/extensions/extension_settings_browsertest.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(dbeam): test for loading upacked extensions?
 
 GEN('#include "chrome/browser/ui/webui/extensions/' +
     'extension_settings_browsertest.h"');
 
+// chrome/test/data/extensions/good.crx's extension ID. good.crx is loaded by
+// ExtensionSettingsUIBrowserTest::InstallGoodExtension() in some of the tests.
+var GOOD_CRX_ID = 'ldnnhddmnhbkjipkidpdiheffobcpfmf';
+
 /**
  * Test C++ fixture for settings WebUI testing.
  * @constructor
  * @extends {testing.Test}
  */
 function ExtensionSettingsUIBrowserTest() {}
 
 /**
  * TestFixture for extension settings WebUI testing.
  * @extends {testing.Test}
@@ skipping 88 matching lines @@
     function() {
   // Just navigating to the page should trigger the chrome.send().
   assertEquals(this.browsePreload, document.location.href);
   assertTrue($('extension-commands-overlay').classList.contains('showing'));
 });
 
 /**
  * @constructor
  * @extends {ExtensionSettingsWebUITest}
  */
-function ExtensionSettingsWebUITestWithExtensionInstalled() {}
+function InstalledExtensionSettingsWebUITest() {}
 
-ExtensionSettingsWebUITestWithExtensionInstalled.prototype = {
+InstalledExtensionSettingsWebUITest.prototype = {
   __proto__: ExtensionSettingsWebUITest.prototype,
 
   /** @override */
   typedefCppFixture: 'ExtensionSettingsUIBrowserTest',
 
   /** @override */
   testGenPreamble: function() {
     GEN('  InstallGoodExtension();');
-  }
+  },
 };
 
-/** @this {ExtensionSettingsWebUITestWithExtensionInstalled} */
+/** @this {InstalledExtensionSettingsWebUITest} */
 function runAudit() {
   assertEquals(this.browsePreload, document.location.href);
   this.runAccessibilityAudit();
 }
 
-TEST_F('ExtensionSettingsWebUITestWithExtensionInstalled',
-       'baseAccessibilityIsOk', runAudit);
+TEST_F('InstalledExtensionSettingsWebUITest', 'baseAccessibilityOk', runAudit);
 
 /**
  * @constructor
- * @extends {ExtensionSettingsWebUITestWithExtensionInstalled}
+ * @extends {InstalledExtensionSettingsWebUITest}
+ */
+function AsyncInstalledExtensionSettingsWebUITest() {}
+
+AsyncInstalledExtensionSettingsWebUITest.prototype = {
+  __proto__: InstalledExtensionSettingsWebUITest.prototype,
+
+  /** @override */
+  isAsync: true,
+};
+
+TEST_F('AsyncInstalledExtensionSettingsWebUITest', 'showOptions', function() {
+  var optionsOverlay = extensions.ExtensionOptionsOverlay.getInstance();
+  optionsOverlay.setExtensionAndShowOverlay(GOOD_CRX_ID, 'GOOD!', '', testDone);
+
+  // Preferred size changes don't happen in browser tests. Just fake it.
+  var size = {width: 500, height: 500};
+  document.querySelector('extensionoptions').onpreferredsizechanged(size);
+});
+
+/**
+ * @constructor
+ * @extends {InstalledExtensionSettingsWebUITest}
  */
 function ManagedExtensionSettingsWebUITest() {}
 
 ManagedExtensionSettingsWebUITest.prototype = {
-  __proto__: ExtensionSettingsWebUITestWithExtensionInstalled.prototype,
+  __proto__: InstalledExtensionSettingsWebUITest.prototype,
 
   /** @override */
   testGenPreamble: function() {
     GEN('  AddManagedPolicyProvider();');
-    ExtensionSettingsWebUITestWithExtensionInstalled.prototype.testGenPreamble.
-        call(this);
+    InstalledExtensionSettingsWebUITest.prototype.testGenPreamble.call(this);
   },
 };
 
 TEST_F('ManagedExtensionSettingsWebUITest', 'testAccessibility', runAudit);
 
 /**
  * @constructor
- * @extends {ExtensionSettingsWebUITestWithExtensionInstalled}
+ * @extends {InstalledExtensionSettingsWebUITest}
  */
-function ExtensionOptionsDialogsWebUITest() {}
+function ExtensionOptionsDialogWebUITest() {}
 
-ExtensionOptionsDialogsWebUITest.prototype = {
-  __proto__: ExtensionSettingsWebUITestWithExtensionInstalled.prototype,
+ExtensionOptionsDialogWebUITest.prototype = {
+  __proto__: InstalledExtensionSettingsWebUITest.prototype,
 
   /** @override */
   browsePreload: ExtensionSettingsWebUITest.prototype.browsePreload +
-      '?options=ldnnhddmnhbkjipkidpdiheffobcpfmf',
+      '?options=' + GOOD_CRX_ID,
 };
 
-TEST_F('ExtensionOptionsDialogsWebUITest', 'testAccessibility', runAudit);
+TEST_F('ExtensionOptionsDialogWebUITest', 'testAccessibility', runAudit);