win: Fixes for minidump_misc_info_writer_test.cc

win: Fixes for minidump_misc_info_writer_test.cc

MINIDUMP_MISC_INFO and MINIDUMP_MISC_INFO_2, etc. are not
derived from each other in Windows' dbghelp.h, so need
a reinterpret_cast.

arraysize fails on Struct::Member with a big mess (below)
but works ok on a local stack instance.

d:\src\crashpad\crashpad\minidump\minidump_misc_info_writer_test.cc(405) : error C2664: 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>::basic_string(std::initializer_list<_Elem>,const std::allocator<char> &)' : cannot convert argument 1 from 'char' to 'const std::basic_string<char,std::char_traits<char>,std::allocator<char>> &'
        with
        [
            _Elem=char
        ]
        Reason: cannot convert from 'char' to 'const std::basic_string<char,std::char_traits<char>,std::allocator<char>>'
        No constructor could take the source type, or constructor overload resolution was ambiguous
d:\src\crashpad\crashpad\minidump\minidump_misc_info_writer_test.cc(408) : error C2784: 'char (&ArraySizeHelper(const T (&)[N]))[N]' : could not deduce template argument for 'const T (&)[N]' from 'unknown'
        d:\src\crashpad\crashpad\third_party\mini_chromium\mini_chromium\base\basictypes.h(39) : see declaration of 'ArraySizeHelper'


R=mark@chromium.org
BUG=crashpad:1
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/2d2ad633eaae0156f8eb1a54e1c231edb9267753

[Mark Mentovai, 2015-02-05 14:31:36]

https://codereview.chromium.org/899163004/diff/1/minidump/minidump_misc_info_...
File minidump/minidump_misc_info_writer_test.cc (right):

https://codereview.chromium.org/899163004/diff/1/minidump/minidump_misc_info_...
minidump/minidump_misc_info_writer_test.cc:401: MINIDUMP_MISC_INFO_N tmp;
(void)tmp;
Add ALLOW_UNUSED_LOCAL to mini_chromium and use it here. See
https://codereview.chromium.org/886143004/ too.

https://codereview.chromium.org/899163004/diff/1/minidump/minidump_misc_info_...
minidump/minidump_misc_info_writer_test.cc:491: MINIDUMP_MISC_INFO_4 tmp;
(void)tmp;
Here too.

https://codereview.chromium.org/899163004/diff/1/minidump/minidump_misc_info_...
minidump/minidump_misc_info_writer_test.cc:492: std::string
build_string(arraysize(tmp.BuildString) + 1, 'B');
Nice, the local variable makes these lines less ugly.

[scottmg, 2015-02-05 17:04:28]

https://codereview.chromium.org/899163004/diff/1/minidump/minidump_misc_info_...
File minidump/minidump_misc_info_writer_test.cc (right):

https://codereview.chromium.org/899163004/diff/1/minidump/minidump_misc_info_...
minidump/minidump_misc_info_writer_test.cc:401: MINIDUMP_MISC_INFO_N tmp;
(void)tmp;
On 2015/02/05 14:31:35, Mark Mentovai wrote:
> Add ALLOW_UNUSED_LOCAL to mini_chromium and use it here. See
> https://codereview.chromium.org/886143004/ too.

Done.

https://codereview.chromium.org/899163004/diff/1/minidump/minidump_misc_info_...
minidump/minidump_misc_info_writer_test.cc:491: MINIDUMP_MISC_INFO_4 tmp;
(void)tmp;
On 2015/02/05 14:31:35, Mark Mentovai wrote:
> Here too.

Done.

[Mark Mentovai, 2015-02-05 17:12:19]

LGTM with or after DEPS roll.

[scottmg, 2015-02-05 17:35:58]

Committed patchset #2 (id:20001) manually as
2d2ad633eaae0156f8eb1a54e1c231edb9267753 (presubmit successful).